Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7eb8234f
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ef979d47
Choose a head ref
  • 5 commits
  • 23 files changed
  • 3 contributors

Commits on Dec 18, 2024

  1. [flags] Delete enableSchedulerDebugger (#31826) 

    The tool for this isn't used so I killed it internally and we can clean
up the code to make it easier to reduce the scheduler code.
    @rickhanlonii
    rickhanlonii authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    1e9ef39 View commit details
    Browse the repository at this point in the history

  2. [tests] <StrictMode /> nested in tree is broken (#31825) 

    Adds a test that shows using <StrictMode /> anywhere outside of the root
node will not fire strict effects.

This works:

```js
root.render(
  <StrictMode>
    <App>
      <Children />
    </App>
  </StrictMode>
);
  ```
  
  This does not fire strict effects on mount:
```js
root.render(
  <App>
    <StrictMode>
      <Children />
    </StrictMode>
  </App>
);
```
    @rickhanlonii
    rickhanlonii authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    e1d843f View commit details
    Browse the repository at this point in the history

  3. [flags] Remove enableModernStrictMode (#31838) 

    This is enabled everywhere.
    @rickhanlonii
    rickhanlonii authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    74dd2da View commit details
    Browse the repository at this point in the history

  4. Allow <script> and <template> tags in <select> tag (#31837)

    @jonathanhefner
    jonathanhefner authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    95465dc View commit details
    Browse the repository at this point in the history

  5. [Flight Reply] Reject any new Chunks not yet discovered at the time o… 

    …f reportGlobalError (#31840)

We might have already resolved models that are not pending and so are
not rejected by aborting the stream. When those later get parsed they
might discover new chunks which end up as pending. These should be
errored since they will never be able to resolve later.

This avoids infinitely hanging the stream.

This same fix needs to be ported to ReactFlightClient that has the same
issue.
    @sebmarkbage
    sebmarkbage authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    ef979d4 View commit details
    Browse the repository at this point in the history
Loading