[Flight Reply] Reject any new Chunks not yet discovered at the time of reportGlobalError #31840
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
approved these changes
Dec 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…f reportGlobalError (#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue. DiffTrain build for [ef979d4](ef979d4)
gnoff
pushed a commit
to gnoff/react
that referenced
this pull request
Dec 18, 2024
…f reportGlobalError (facebook#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue.
This was referenced Dec 18, 2024
gnoff
pushed a commit
to gnoff/react
that referenced
this pull request
Dec 18, 2024
…f reportGlobalError (facebook#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue.
gnoff
added a commit
that referenced
this pull request
Dec 18, 2024
cherry-picks #31840 into the base version of React in latest Next.js 14 release Co-authored-by: Sebastian Markbåge <sebastian@calyptus.eu>
gnoff
pushed a commit
to gnoff/react
that referenced
this pull request
Dec 18, 2024
…f reportGlobalError (facebook#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue.
gnoff
added a commit
that referenced
this pull request
Dec 18, 2024
…at the time of reportGlobalError (#31840) (#31845) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue. Co-authored-by: Sebastian Markbåge <sebastian@calyptus.eu>
gnoff
pushed a commit
to gnoff/react
that referenced
this pull request
Dec 19, 2024
…f reportGlobalError (facebook#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue.
sebmarkbage
added a commit
to sebmarkbage/react
that referenced
this pull request
Dec 19, 2024
ztanner
added a commit
to vercel/next.js
that referenced
this pull request
Dec 19, 2024
…218 (#74117) [diff facebook/react@7283a213...65e06cb7](facebook/react@7283a21...65e06cb) <details> <summary>React upstream changes</summary> - [Merge 4af40315c864c4467aa1a2fb61b9c05b7d180e3e into 7283a213dbbc31029e65005276f12202558558fc facebook/react@65e06cb77](facebook/react@65e06cb) (Josh Story) - facebook/react#31840 </details>
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 19, 2024
…rtGlobalError (facebook#31851) Same as facebook#31840 but for the Flight Client. DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 19, 2024
…rtGlobalError (facebook#31851) Same as facebook#31840 but for the Flight Client. DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot
pushed a commit
to AreaLayer/react
that referenced
this pull request
Dec 19, 2024
…rtGlobalError (facebook#31851) Same as facebook#31840 but for the Flight Client. DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot
pushed a commit
to AreaLayer/react
that referenced
this pull request
Dec 19, 2024
…rtGlobalError (facebook#31851) Same as facebook#31840 but for the Flight Client. DiffTrain build for [a9bbe34](facebook@a9bbe34)
This was referenced Dec 19, 2024
gnoff
pushed a commit
to gnoff/react
that referenced
this pull request
Dec 20, 2024
…f reportGlobalError (facebook#31840) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue.
gnoff
added a commit
that referenced
this pull request
Dec 20, 2024
…at the time of reportGlobalError (#31840) (#31872) We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later. This avoids infinitely hanging the stream. This same fix needs to be ported to ReactFlightClient that has the same issue. Co-authored-by: Sebastian Markbåge <sebastian@calyptus.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might have already resolved models that are not pending and so are not rejected by aborting the stream. When those later get parsed they might discover new chunks which end up as pending. These should be errored since they will never be able to resolve later.
This avoids infinitely hanging the stream.
This same fix needs to be ported to ReactFlightClient that has the same issue.