Skip to content

Commit f0775f3

Browse files
kassenskassens
committed
Performance: avoid triggering map deopt in V8 (#28569)
The shape of the objects changed by this PR are both created in 2 locations with 2 different shapes, which most JS engines won't like. I've noticed this in particular in V8 while benchmarking production code. https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberCacheComponent.js#L66-L77 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHostContext.js#L47-L54 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3530-L3531 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3492-L3493 DiffTrain build for commit 4d686a2.
1 parent fbba8d4 commit f0775f3

File tree

13 files changed

+64
-64
lines changed

13 files changed

+64
-64
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a3b83de91596e95a8c9484b94ff6b74c>>
10+
* @generated SignedSource<<65b88d386b80bb668ee1220244f5891b>>
1111
*/
1212

1313
"use strict";
@@ -2570,11 +2570,11 @@ if (__DEV__) {
25702570

25712571
var HostTransitionContext = {
25722572
$$typeof: REACT_CONTEXT_TYPE,
2573+
Provider: null,
2574+
Consumer: null,
25732575
_currentValue: null,
25742576
_currentValue2: null,
2575-
_threadCount: 0,
2576-
Provider: null,
2577-
Consumer: null
2577+
_threadCount: 0
25782578
};
25792579

25802580
function requiredContext(c) {
@@ -9616,8 +9616,8 @@ if (__DEV__) {
96169616
useContext: throwInvalidHookError,
96179617
useEffect: throwInvalidHookError,
96189618
useImperativeHandle: throwInvalidHookError,
9619-
useInsertionEffect: throwInvalidHookError,
96209619
useLayoutEffect: throwInvalidHookError,
9620+
useInsertionEffect: throwInvalidHookError,
96219621
useMemo: throwInvalidHookError,
96229622
useReducer: throwInvalidHookError,
96239623
useRef: throwInvalidHookError,
@@ -25454,7 +25454,7 @@ if (__DEV__) {
2545425454
return root;
2545525455
}
2545625456

25457-
var ReactVersion = "18.3.0-canary-45d56071b-20240318";
25457+
var ReactVersion = "18.3.0-canary-4d686a2da-20240318";
2545825458

2545925459
// Might add PROFILE later.
2546025460

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f286949b9793004b5a064c2aeef09640>>
10+
* @generated SignedSource<<b8f1ce1ab15d9e71ef26da594ea2a0c5>>
1111
*/
1212

1313
"use strict";
@@ -663,11 +663,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
663663
hostTransitionProviderCursor = createCursor(null),
664664
HostTransitionContext = {
665665
$$typeof: REACT_CONTEXT_TYPE,
666+
Provider: null,
667+
Consumer: null,
666668
_currentValue: null,
667669
_currentValue2: null,
668-
_threadCount: 0,
669-
Provider: null,
670-
Consumer: null
670+
_threadCount: 0
671671
};
672672
function pushHostContainer(fiber, nextRootInstance) {
673673
push(rootInstanceStackCursor, nextRootInstance);
@@ -3109,8 +3109,8 @@ var ContextOnlyDispatcher = {
31093109
useContext: throwInvalidHookError,
31103110
useEffect: throwInvalidHookError,
31113111
useImperativeHandle: throwInvalidHookError,
3112-
useInsertionEffect: throwInvalidHookError,
31133112
useLayoutEffect: throwInvalidHookError,
3113+
useInsertionEffect: throwInvalidHookError,
31143114
useMemo: throwInvalidHookError,
31153115
useReducer: throwInvalidHookError,
31163116
useRef: throwInvalidHookError,
@@ -9175,7 +9175,7 @@ var devToolsConfig$jscomp$inline_1016 = {
91759175
throw Error("TestRenderer does not support findFiberByHostInstance()");
91769176
},
91779177
bundleType: 0,
9178-
version: "18.3.0-canary-45d56071b-20240318",
9178+
version: "18.3.0-canary-4d686a2da-20240318",
91799179
rendererPackageName: "react-test-renderer"
91809180
};
91819181
var internals$jscomp$inline_1194 = {
@@ -9206,7 +9206,7 @@ var internals$jscomp$inline_1194 = {
92069206
scheduleRoot: null,
92079207
setRefreshHandler: null,
92089208
getCurrentFiber: null,
9209-
reconcilerVersion: "18.3.0-canary-45d56071b-20240318"
9209+
reconcilerVersion: "18.3.0-canary-4d686a2da-20240318"
92109210
};
92119211
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
92129212
var hook$jscomp$inline_1195 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e7f6aa2c01048ac2a1b605aae48eb66a>>
10+
* @generated SignedSource<<6adce1bb96c74af6db54e6a23f64cd73>>
1111
*/
1212

1313
"use strict";
@@ -681,11 +681,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
681681
hostTransitionProviderCursor = createCursor(null),
682682
HostTransitionContext = {
683683
$$typeof: REACT_CONTEXT_TYPE,
684+
Provider: null,
685+
Consumer: null,
684686
_currentValue: null,
685687
_currentValue2: null,
686-
_threadCount: 0,
687-
Provider: null,
688-
Consumer: null
688+
_threadCount: 0
689689
};
690690
function pushHostContainer(fiber, nextRootInstance) {
691691
push(rootInstanceStackCursor, nextRootInstance);
@@ -3129,8 +3129,8 @@ var ContextOnlyDispatcher = {
31293129
useContext: throwInvalidHookError,
31303130
useEffect: throwInvalidHookError,
31313131
useImperativeHandle: throwInvalidHookError,
3132-
useInsertionEffect: throwInvalidHookError,
31333132
useLayoutEffect: throwInvalidHookError,
3133+
useInsertionEffect: throwInvalidHookError,
31343134
useMemo: throwInvalidHookError,
31353135
useReducer: throwInvalidHookError,
31363136
useRef: throwInvalidHookError,
@@ -9603,7 +9603,7 @@ var devToolsConfig$jscomp$inline_1058 = {
96039603
throw Error("TestRenderer does not support findFiberByHostInstance()");
96049604
},
96059605
bundleType: 0,
9606-
version: "18.3.0-canary-45d56071b-20240318",
9606+
version: "18.3.0-canary-4d686a2da-20240318",
96079607
rendererPackageName: "react-test-renderer"
96089608
};
96099609
var internals$jscomp$inline_1235 = {
@@ -9634,7 +9634,7 @@ var internals$jscomp$inline_1235 = {
96349634
scheduleRoot: null,
96359635
setRefreshHandler: null,
96369636
getCurrentFiber: null,
9637-
reconcilerVersion: "18.3.0-canary-45d56071b-20240318"
9637+
reconcilerVersion: "18.3.0-canary-4d686a2da-20240318"
96389638
};
96399639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96409640
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (__DEV__) {
2626
}
2727
var dynamicFlags = require("ReactNativeInternalFeatureFlags");
2828

29-
var ReactVersion = "18.3.0-canary-45d56071b-20240318";
29+
var ReactVersion = "18.3.0-canary-4d686a2da-20240318";
3030

3131
// ATTENTION
3232
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,4 +628,4 @@ exports.useSyncExternalStore = function (
628628
exports.useTransition = function () {
629629
return ReactCurrentDispatcher.current.useTransition();
630630
};
631-
exports.version = "18.3.0-canary-45d56071b-20240318";
631+
exports.version = "18.3.0-canary-4d686a2da-20240318";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ exports.useSyncExternalStore = function (
624624
exports.useTransition = function () {
625625
return ReactCurrentDispatcher.current.useTransition();
626626
};
627-
exports.version = "18.3.0-canary-45d56071b-20240318";
627+
exports.version = "18.3.0-canary-4d686a2da-20240318";
628628
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
629629
"function" ===
630630
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
45d56071b8ce1dbccf1765acf3867263fe3e595b
1+
4d686a2da138cad9e76c7de9feadd81ca2aa29e5

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<48c206274b16ddb872dd142a6fc17769>>
10+
* @generated SignedSource<<e0529a44eea2a06c29b44e0f6f3094ea>>
1111
*/
1212

1313
"use strict";
@@ -6050,11 +6050,11 @@ to return true:wantsResponderID| |
60506050

60516051
var HostTransitionContext = {
60526052
$$typeof: REACT_CONTEXT_TYPE,
6053+
Provider: null,
6054+
Consumer: null,
60536055
_currentValue: null,
60546056
_currentValue2: null,
6055-
_threadCount: 0,
6056-
Provider: null,
6057-
Consumer: null
6057+
_threadCount: 0
60586058
};
60596059

60606060
function requiredContext(c) {
@@ -13570,8 +13570,8 @@ to return true:wantsResponderID| |
1357013570
useContext: throwInvalidHookError,
1357113571
useEffect: throwInvalidHookError,
1357213572
useImperativeHandle: throwInvalidHookError,
13573-
useInsertionEffect: throwInvalidHookError,
1357413573
useLayoutEffect: throwInvalidHookError,
13574+
useInsertionEffect: throwInvalidHookError,
1357513575
useMemo: throwInvalidHookError,
1357613576
useReducer: throwInvalidHookError,
1357713577
useRef: throwInvalidHookError,
@@ -29801,7 +29801,7 @@ to return true:wantsResponderID| |
2980129801
return root;
2980229802
}
2980329803

29804-
var ReactVersion = "18.3.0-canary-01f0d8b1";
29804+
var ReactVersion = "18.3.0-canary-dcb437de";
2980529805

2980629806
function createPortal$1(
2980729807
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f468fcfeadb843d99ac63af6cde06553>>
10+
* @generated SignedSource<<bad8dcf29728fb2c7ec3ee84033aabb1>>
1111
*/
1212

1313
"use strict";
@@ -2001,11 +2001,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
20012001
hostTransitionProviderCursor = createCursor(null),
20022002
HostTransitionContext = {
20032003
$$typeof: REACT_CONTEXT_TYPE,
2004+
Provider: null,
2005+
Consumer: null,
20042006
_currentValue: null,
20052007
_currentValue2: null,
2006-
_threadCount: 0,
2007-
Provider: null,
2008-
Consumer: null
2008+
_threadCount: 0
20092009
};
20102010
function pushHostContainer(fiber, nextRootInstance) {
20112011
push(rootInstanceStackCursor, nextRootInstance);
@@ -4724,8 +4724,8 @@ var ContextOnlyDispatcher = {
47244724
useContext: throwInvalidHookError,
47254725
useEffect: throwInvalidHookError,
47264726
useImperativeHandle: throwInvalidHookError,
4727-
useInsertionEffect: throwInvalidHookError,
47284727
useLayoutEffect: throwInvalidHookError,
4728+
useInsertionEffect: throwInvalidHookError,
47294729
useMemo: throwInvalidHookError,
47304730
useReducer: throwInvalidHookError,
47314731
useRef: throwInvalidHookError,
@@ -10626,7 +10626,7 @@ var roots = new Map(),
1062610626
devToolsConfig$jscomp$inline_1103 = {
1062710627
findFiberByHostInstance: getInstanceFromNode,
1062810628
bundleType: 0,
10629-
version: "18.3.0-canary-8f98d002",
10629+
version: "18.3.0-canary-45ebe421",
1063010630
rendererPackageName: "react-native-renderer",
1063110631
rendererConfig: {
1063210632
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10669,7 +10669,7 @@ var internals$jscomp$inline_1330 = {
1066910669
scheduleRoot: null,
1067010670
setRefreshHandler: null,
1067110671
getCurrentFiber: null,
10672-
reconcilerVersion: "18.3.0-canary-8f98d002"
10672+
reconcilerVersion: "18.3.0-canary-45ebe421"
1067310673
};
1067410674
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1067510675
var hook$jscomp$inline_1331 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6c9f7fe03ad0703b972eef9473b57c69>>
10+
* @generated SignedSource<<26c28bc563c475bc48b8350e745dfaa4>>
1111
*/
1212

1313
"use strict";
@@ -2123,11 +2123,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
21232123
hostTransitionProviderCursor = createCursor(null),
21242124
HostTransitionContext = {
21252125
$$typeof: REACT_CONTEXT_TYPE,
2126+
Provider: null,
2127+
Consumer: null,
21262128
_currentValue: null,
21272129
_currentValue2: null,
2128-
_threadCount: 0,
2129-
Provider: null,
2130-
Consumer: null
2130+
_threadCount: 0
21312131
};
21322132
function pushHostContainer(fiber, nextRootInstance) {
21332133
push(rootInstanceStackCursor, nextRootInstance);
@@ -4851,8 +4851,8 @@ var ContextOnlyDispatcher = {
48514851
useContext: throwInvalidHookError,
48524852
useEffect: throwInvalidHookError,
48534853
useImperativeHandle: throwInvalidHookError,
4854-
useInsertionEffect: throwInvalidHookError,
48554854
useLayoutEffect: throwInvalidHookError,
4855+
useInsertionEffect: throwInvalidHookError,
48564856
useMemo: throwInvalidHookError,
48574857
useReducer: throwInvalidHookError,
48584858
useRef: throwInvalidHookError,
@@ -11332,7 +11332,7 @@ var roots = new Map(),
1133211332
devToolsConfig$jscomp$inline_1184 = {
1133311333
findFiberByHostInstance: getInstanceFromNode,
1133411334
bundleType: 0,
11335-
version: "18.3.0-canary-e8e1a13c",
11335+
version: "18.3.0-canary-154313d4",
1133611336
rendererPackageName: "react-native-renderer",
1133711337
rendererConfig: {
1133811338
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11388,7 +11388,7 @@ var roots = new Map(),
1138811388
scheduleRoot: null,
1138911389
setRefreshHandler: null,
1139011390
getCurrentFiber: null,
11391-
reconcilerVersion: "18.3.0-canary-e8e1a13c"
11391+
reconcilerVersion: "18.3.0-canary-154313d4"
1139211392
});
1139311393
exports.createPortal = function (children, containerTag) {
1139411394
return createPortal$1(

0 commit comments

Comments
 (0)