Use memoizedState in componentDidUpdate

We forgot to clone this value so it didn't work before. This is covered by existing tests in ReactDOMProduction.
facebook · Oct 11, 2016 · d2fe722 · d2fe722
1 parent ed448c9
commit d2fe722
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/renderers/shared/fiber/ReactFiber.js b/src/renderers/shared/fiber/ReactFiber.js
@@ -253,6 +253,7 @@ exports.cloneFiber = function(fiber : Fiber, priorityLevel : PriorityLevel) : Fi
   alt.pendingWorkPriority = priorityLevel;
 
   alt.memoizedProps = fiber.memoizedProps;
+  alt.memoizedState = fiber.memoizedState;
   alt.output = fiber.output;
 
   return alt;

diff --git a/src/renderers/shared/fiber/ReactFiberCommitWork.js b/src/renderers/shared/fiber/ReactFiberCommitWork.js
@@ -291,7 +291,7 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) {
             const prevProps = current.memoizedProps;
             // TODO: This is the new state. We don't currently have the previous
             // state anymore.
-            const prevState = instance.state || null;
+            const prevState = current.memoizedState;
             instance.componentDidUpdate(prevProps, prevState);
           }
         }