-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9168 #9179
Closed
Closed
Fixes #9168 #9179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
GH Review: review-needed
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
labels
Aug 3, 2016
cc: @rozele |
Ping me when tests will be green |
Cool. BTW that is the only commit AFAIK we had to import :) |
ghost
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 3, 2016
Yeah, I think so as well. LGTM, let's ship it! |
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
This pull request has been imported. This does not imply the PR has been approved.
and removed
GH Review: review-needed
labels
Aug 3, 2016
Thanks for importing. |
ghost
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 3, 2016
ghost
closed this
in
Aug 3, 2016
4fce8ea
ghost
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 3, 2016
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: Imports missing commit from the rnpm master. Closes facebook#9179 Differential Revision: D3661909 fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Imports missing commit from the rnpm master. Closes facebook#9179 Differential Revision: D3661909 fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Imports missing commit from the rnpm master. Closes facebook#9179 Differential Revision: D3661909 fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
grabbou
added a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Imports missing commit from the rnpm master. Closes facebook/react-native#9179 Differential Revision: D3661909 fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports missing commit from the rnpm master.