Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9168 #9179

Closed
wants to merge 1 commit into from
Closed

Fixes #9168 #9179

wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Aug 3, 2016

Imports missing commit from the rnpm master.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 3, 2016
@grabbou
Copy link
Contributor Author

grabbou commented Aug 3, 2016

cc: @rozele

@Kureev
Copy link
Contributor

Kureev commented Aug 3, 2016

Ping me when tests will be green

@grabbou
Copy link
Contributor Author

grabbou commented Aug 3, 2016

Cool. BTW that is the only commit AFAIK we had to import :)

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2016
@Kureev
Copy link
Contributor

Kureev commented Aug 3, 2016

Yeah, I think so as well. LGTM, let's ship it!

@Kureev
Copy link
Contributor

Kureev commented Aug 3, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 3, 2016
@facebook-github-bot
Copy link
Contributor

Thanks for importing.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2016
@ghost ghost closed this in 4fce8ea Aug 3, 2016
@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2016
bartolkaruza pushed a commit to immidi/react-native that referenced this pull request Aug 3, 2016
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
grabbou added a commit that referenced this pull request Aug 5, 2016
Summary:
Imports missing commit from the rnpm master.
Closes #9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
Imports missing commit from the rnpm master.
Closes facebook#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
grabbou added a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
Imports missing commit from the rnpm master.
Closes facebook/react-native#9179

Differential Revision: D3661909

fbshipit-source-id: 23ebd3b96f236ab140f91eb4ed9f456d7c925027
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants