fix NullPointerException Caused by manageChildren#8991
Closed
ASCE1885 wants to merge 9 commits intofacebook:masterfrom
Closed
fix NullPointerException Caused by manageChildren#8991ASCE1885 wants to merge 9 commits intofacebook:masterfrom
ASCE1885 wants to merge 9 commits intofacebook:masterfrom
Conversation
update react native
|
By analyzing the blame information on this pull request, we identified @dmmiller and @janicduplessis to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
There is a lot of random clean up in here in other files. Can you remove that or do those as separate PRs? Either way, this one should be focused on just fixing the NPE. |
|
I'm also more concerned why we are getting a tag that doesn't match a view at this point rather than protecting against it. Seems like something went wrong further up the stack we should fix. |
Contributor
Author
|
@dmmiller I have revert the other commits, you may try again,thx! |
ghost
added
the
CLA Signed
|
Thanks! @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Closes facebook#8991 Differential Revision: D3612777 Pulled By: dmmiller fbshipit-source-id: d8da5ef8354cdaf55d8a3efbc2bfbc2aef74a044
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.