added new sizes to ActivityIndicator #8640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added medium and extralarge
|
By analyzing the blame information on this pull request, we identified @janicduplessis and @davidaurelio to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -41,7 +41,9 @@ var ActivityIndicatorIOS = React.createClass({ | |||
| */ | |||
| size: PropTypes.oneOf([ | |||
| 'small', | |||
| 'medium', | |||
There was a problem hiding this comment.
This is needed I think since this component is deprecated?
|
What about instead of adding more predefined sizes we allow passing an arbitrary number to size? |
|
@janicduplessis since this is my first contribution I didn't want to mess around with the code too much. I will look into this again when I have some time. |
ghost
added
the
CLA Signed
|
#8935 added custom sizes so we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docs on ActivityIndicator say that:
But when using scale transform the pixels are blown out in iOS (haven't tested on Android).
For example when using this:
This is the zoomed result where you can clearly see the aliasing on the spinner is the result of an interpolation compared to the pixels of the text.
Solution
To remedy this, I've created two new sizes
mediumandextralargeso that these new sizes can be used without having to resort to usingtransform: [{scale: 2}]which I presume is causing the interpolation problem.