Closed
Conversation
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ide
pushed a commit
that referenced
this pull request
Jul 2, 2016
Summary: **Motivation** This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods. **Test plan (required)** Tested with the code in `NativeAnimationsExample.js` and this: ``` pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native' ``` Closes #8487 Differential Revision: D3502970 fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: **Motivation** This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods. **Test plan (required)** Tested with the code in `NativeAnimationsExample.js` and this: ``` pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native' ``` Closes facebook#8487 Differential Revision: D3502970 fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: **Motivation** This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods. **Test plan (required)** Tested with the code in `NativeAnimationsExample.js` and this: ``` pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native' ``` Closes facebook#8487 Differential Revision: D3502970 fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a subspec for the
NativeAnimationiOS library which so one can use it with CocoaPods.Test plan (required)
Tested with the code in
NativeAnimationsExample.jsand this: