-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add zIndex support #7825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tuckerconnelly
wants to merge
19
commits into
facebook:master
from
tuckerconnelly:feature/z-index-cherrypick-2
Closed
Add zIndex support #7825
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
61ef53b
Add zIndex support
tuckerconnelly 028ebb1
Add zIndex support for View on Android 16
tuckerconnelly 053555e
Add zIndex support to the rest of the Android views
tuckerconnelly 5c4742a
Add ZIndex UIExplorer example
tuckerconnelly 454e0cb
Update UIExplorer snapshot tests
tuckerconnelly 0750816
Update View snapshot test
tuckerconnelly 365d970
Fix zIndex on Android TextView
tuckerconnelly 8005b3c
Fix zIndex in IOS WebView
tuckerconnelly 07f7164
Add zIndex support for View on Android 16
tuckerconnelly 8403cd7
Add zIndex support to the rest of the Android views
tuckerconnelly a2c61fb
Update UIExplorer snapshot tests
tuckerconnelly de2e2b7
Update View snapshot test
tuckerconnelly 20df9f5
Remove zPosition implementation of zIndex
tuckerconnelly d869134
Revert all zIndex work
tuckerconnelly 9a215b1
Implement Android zIndex using WeakHashMap
tuckerconnelly 376b2ee
Add back zIndex propType
tuckerconnelly 748d6cc
Remove lingering zIndex getters/setters from ReactImageView
tuckerconnelly 28f5f75
Fix Views not getting z-ordered on load
tuckerconnelly 340382d
Add optimization to not z-order when there are no z-indexed views
tuckerconnelly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-25.3 KB
(83%)
...eferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testLayoutExample_1@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+42.2 KB
(140%)
.../ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testViewExample_1@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason this can't be
int
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmm all the other numerical props were float, so I just copied those. I'm guessing this is because React only has PropTypes.number, which is basically float.
I can totally make a custom integer PropType though. Will need to test how the bridge reacts if you still sent a float through, and the setZIndex param is int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs for
@ReactProp
says it can be a float but yeah, just test it and if it doesn't work don't worry about it and use float.