[Android] fix border style without borderRadius #6789

skv-headless · 2016-04-03T21:33:06Z

closes #6721 closes #3159
before(without borderRadius)

after

facebook-github-bot · 2016-04-03T21:33:18Z

By analyzing the blame information on this pull request, we identified @spicyj, @mkonicek and @vjeux to be potential reviewers.

chirag04 · 2016-04-03T22:42:56Z

will also fix #3159.

I haven't tested this change tho.

ide · 2016-04-04T01:45:46Z

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java

@@ -95,7 +95,7 @@

  @Override
  public void draw(Canvas canvas) {
-    if ((!CSSConstants.isUndefined(mBorderRadius) && mBorderRadius > 0) || mBorderCornerRadii != null) {
+    if ((!CSSConstants.isUndefined(mBorderRadius) && mBorderRadius > 0) || mBorderCornerRadii != null || mBorderStyle != null) {


Can you check for "solid" too?

skv-headless · 2016-04-04T15:04:30Z

@ide please don't merge. In that solution there is problem with changing border style. I need more time to explore code.

facebook-github-bot · 2016-04-04T21:04:42Z

@skv-headless updated the pull request.

skv-headless · 2016-04-04T21:22:50Z

@ide done. But variable names are not obvious. And I'm not sure about difference between drawRoundedBackgroundWithBorders and drawRectangularBackgroundWithBorders

skv-headless · 2016-04-06T13:25:58Z

@ide Do I need to explain something?

ide · 2016-04-06T21:08:35Z

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java

@@ -322,6 +327,7 @@ private int getFullBorderColor() {
  }

  private void drawRectangularBackgroundWithBorders(Canvas canvas) {
+    updatePathEffectForBorderStyle();


Can this call go above line 341?

mkonicek · 2016-04-07T14:08:11Z

@kmagiera What do you think?

facebook-github-bot · 2016-04-11T09:21:14Z

@skv-headless updated the pull request.

skv-headless · 2016-04-11T09:24:11Z

Do I need to do something else? My changes are pretty straightforward.

mkonicek · 2016-04-11T10:11:18Z

@skv-headless This is waiting for a review by @kmagiera who I believe has context on this part of the codebase. If he doesn't get back to you in a few days please ping me.

facebook-github-bot · 2016-04-16T18:04:15Z

@skv-headless updated the pull request.

satya164 · 2016-04-16T21:46:00Z

ping @mkonicek

mkonicek · 2016-04-21T14:40:57Z

Examples/UIExplorer/ViewExample.js

@@ -46,7 +46,6 @@ var ViewBorderStyleExample = React.createClass({
        <View>
          <View style={{
            borderWidth: 1,
-            borderRadius: 5,


Why remove the border radius from the example?

To show that this patch is working.

mkonicek · 2016-04-21T14:47:54Z

Thanks for the fix! Looks good, just some small nits.

facebook-github-bot · 2016-04-25T08:21:14Z

@skv-headless updated the pull request.

skv-headless · 2016-04-25T08:21:52Z

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java

+    boolean roundedBorders = mBorderCornerRadii != null ||
+        (!CSSConstants.isUndefined(mBorderRadius) && mBorderRadius > 0);
+
+    if ((mBorderStyle == null || mBorderStyle == BorderStyle.SOLID) && !roundedBorders) {


I did this condition because I'm not sure how to call (mBorderStyle == null || mBorderStyle == BorderStyle.SOLID) this condition

skv-headless · 2016-04-25T08:23:40Z

@mkonicek I've updated PR. Sorry for delay I was really busy 😫

facebook-github-bot · 2016-04-25T08:25:19Z

@skv-headless updated the pull request.

call drawRoundedBackgroundWithBorders if borderStyle set

ghost · 2016-04-26T17:00:31Z

@skv-headless do you have any updates for this pull request? It's been a while so we wanted to check in and see if you've looked at the requested changes.

skv-headless · 2016-04-27T11:56:15Z

@mkonicek ping

mkonicek · 2016-04-29T11:05:49Z

No problem @skv-headless, sorry on the delay on my side too :)

@facebook-github-bot shipit

ghost · 2016-04-29T11:07:48Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

bestander · 2016-04-29T21:47:44Z

@mkonicek @skv-headless this change broke ObjC tests.
Please consider Travis build status https://travis-ci.org/facebook/react-native/builds/125507502

Considering that it is a long weekend ahead of us we don't want to have a red trunk I'll do a revert.
Please try one more time with Obj-C tests fixed :)

bestander · 2016-04-29T22:36:16Z

see #7303

janicduplessis · 2016-04-30T00:08:57Z

Is it documented anywhere how to update the snapshot tests? I know @grabbou had to do it a few days ago maybe he can help.

bestander · 2016-04-30T00:16:55Z

I think it is not documented but it is relatively straight forward.
You just need to run the failing test with XCode.
Every snapshot test has a setting "generate" or something.
Setting it to true would generate and replace the old snapshot with the new
one.
If you can't figure it out I'll help out next week :)

On Sat, Apr 30, 2016 at 1:10 AM, Janic Duplessis notifications@github.com
wrote:

Is it documented anywhere how to update the snapshot tests? I know
@grabbou https://github.com/grabbou had to do it a few days ago maybe
he can help.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#6789 (comment)

grabbou · 2016-04-30T08:21:51Z

@janicduplessis thanks for the reminder, I am on that ;)

Summary: closes facebook#6721 closes facebook#3159 before(without borderRadius) ![bug](https://cloud.githubusercontent.com/assets/1488195/14235087/fcf79f8a-f9eb-11e5-9d44-7ab1d131be24.jpg) after ![fix](https://cloud.githubusercontent.com/assets/1488195/14235067/8cf128b4-f9eb-11e5-8170-ad3a146d6104.jpg) Closes facebook#6789 Differential Revision: D3240657 Pulled By: mkonicek fb-gh-sync-id: 4eb8f72d7278d880297fb73653ef530719af3d5b fbshipit-source-id: 4eb8f72d7278d880297fb73653ef530719af3d5b

closes facebook#6789

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 3, 2016

skv-headless force-pushed the fix-border-style branch from 8106095 to 06ca452 Compare April 3, 2016 22:07

skv-headless changed the title ~~fix border style without borderRadius~~ [Android] fix border style without borderRadius Apr 3, 2016

ide reviewed Apr 4, 2016
View reviewed changes

skv-headless force-pushed the fix-border-style branch from 06ca452 to b0521f8 Compare April 4, 2016 21:04

skv-headless force-pushed the fix-border-style branch from b0521f8 to be11548 Compare April 6, 2016 13:25

ide reviewed Apr 6, 2016
View reviewed changes

skv-headless force-pushed the fix-border-style branch 2 times, most recently from 8f3d0fd to 2d9bab6 Compare April 11, 2016 09:20

skv-headless force-pushed the fix-border-style branch from 2d9bab6 to 76dcc31 Compare April 16, 2016 18:03

grabbou assigned mkonicek Apr 20, 2016

mkonicek reviewed Apr 21, 2016
View reviewed changes

mkonicek added the GH Review: needs-revision label Apr 21, 2016

skv-headless force-pushed the fix-border-style branch from 76dcc31 to b04b10f Compare April 25, 2016 08:20

skv-headless reviewed Apr 25, 2016
View reviewed changes

skv-headless force-pushed the fix-border-style branch from b04b10f to cc7a78f Compare April 25, 2016 08:24

fix border style without borderRadius

cc7a78f

call drawRoundedBackgroundWithBorders if borderStyle set

ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: needs-revision labels Apr 29, 2016

ghost closed this in 58876d5 Apr 29, 2016

skv-headless mentioned this pull request May 4, 2016

Revert "Revert "fix border style without borderRadius"" #7389

Closed

waquidvp mentioned this pull request Dec 27, 2017

borderStyle cannot working (v0.47.2 on Android) #17344

Closed

react-one pushed a commit to react-one/react-native that referenced this pull request Sep 24, 2021

fix: initialize height and width to zero if undefined

3df65e2

closes facebook#6789

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] fix border style without borderRadius #6789

[Android] fix border style without borderRadius #6789

skv-headless commented Apr 3, 2016

facebook-github-bot commented Apr 3, 2016

chirag04 commented Apr 3, 2016

ide Apr 4, 2016

skv-headless commented Apr 4, 2016

facebook-github-bot commented Apr 4, 2016

skv-headless commented Apr 4, 2016

skv-headless commented Apr 6, 2016

ide Apr 6, 2016

mkonicek commented Apr 7, 2016

facebook-github-bot commented Apr 11, 2016

skv-headless commented Apr 11, 2016

mkonicek commented Apr 11, 2016

facebook-github-bot commented Apr 16, 2016

satya164 commented Apr 16, 2016

mkonicek Apr 21, 2016

skv-headless Apr 23, 2016

mkonicek commented Apr 21, 2016

facebook-github-bot commented Apr 25, 2016

skv-headless Apr 25, 2016

skv-headless commented Apr 25, 2016

facebook-github-bot commented Apr 25, 2016

ghost commented Apr 26, 2016

skv-headless commented Apr 27, 2016

mkonicek commented Apr 29, 2016

ghost commented Apr 29, 2016

bestander commented Apr 29, 2016

bestander commented Apr 29, 2016

janicduplessis commented Apr 30, 2016

bestander commented Apr 30, 2016

grabbou commented Apr 30, 2016

[Android] fix border style without borderRadius #6789

[Android] fix border style without borderRadius #6789

Conversation

skv-headless commented Apr 3, 2016

facebook-github-bot commented Apr 3, 2016

chirag04 commented Apr 3, 2016

ide Apr 4, 2016

Choose a reason for hiding this comment

skv-headless commented Apr 4, 2016

facebook-github-bot commented Apr 4, 2016

skv-headless commented Apr 4, 2016

skv-headless commented Apr 6, 2016

ide Apr 6, 2016

Choose a reason for hiding this comment

mkonicek commented Apr 7, 2016

facebook-github-bot commented Apr 11, 2016

skv-headless commented Apr 11, 2016

mkonicek commented Apr 11, 2016

facebook-github-bot commented Apr 16, 2016

satya164 commented Apr 16, 2016

mkonicek Apr 21, 2016

Choose a reason for hiding this comment

skv-headless Apr 23, 2016

Choose a reason for hiding this comment

mkonicek commented Apr 21, 2016

facebook-github-bot commented Apr 25, 2016

skv-headless Apr 25, 2016

Choose a reason for hiding this comment

skv-headless commented Apr 25, 2016

facebook-github-bot commented Apr 25, 2016

ghost commented Apr 26, 2016

skv-headless commented Apr 27, 2016

mkonicek commented Apr 29, 2016

ghost commented Apr 29, 2016

bestander commented Apr 29, 2016

bestander commented Apr 29, 2016

janicduplessis commented Apr 30, 2016

bestander commented Apr 30, 2016

grabbou commented Apr 30, 2016