fontFamily and color support for TextInput secureTextEntry={true} #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@brunobar79 updated the pull request. |
brentvatne
changed the title
|
Can you separate color and font family into separate PRs? Just to decouple changes? And there is another PR for color that I've seen (#6064). I think yours is more robust to the null case which is good, but it was nice they added a sample of it working. |
This was referenced Mar 21, 2016
ghost
pushed a commit
that referenced
this pull request
Mar 21, 2016
Summary:Color property is ignored for TextInput with secureTextEntry={true} on Android.
This is coming from #6540 and being split into 2 PRs by suggestion of dmmiller.
As he mentioned does almost the same except it #6064 doesn't handle null case.
Working example:
Closes #6563
Differential Revision: D3077583
Pulled By: mkonicek
fb-gh-sync-id: f0761346b77060abf17f1d4573b375adebc5c607
shipit-source-id: f0761346b77060abf17f1d4573b375adebc5c607
jeffchienzabinet
pushed a commit
to jeffchienzabinet/react-native
that referenced
this pull request
Mar 21, 2016
Summary:Color property is ignored for TextInput with secureTextEntry={true} on Android.
This is coming from facebook#6540 and being split into 2 PRs by suggestion of dmmiller.
As he mentioned does almost the same except it facebook#6064 doesn't handle null case.
Working example:
Closes facebook#6563
Differential Revision: D3077583
Pulled By: mkonicek
fb-gh-sync-id: f0761346b77060abf17f1d4573b375adebc5c607
shipit-source-id: f0761346b77060abf17f1d4573b375adebc5c607
machard
pushed a commit
to machard/react-native
that referenced
this pull request
Apr 7, 2016
Summary:Color property is ignored for TextInput with secureTextEntry={true} on Android.
This is coming from facebook#6540 and being split into 2 PRs by suggestion of dmmiller.
As he mentioned does almost the same except it facebook#6064 doesn't handle null case.
Working example:
Closes facebook#6563
Differential Revision: D3077583
Pulled By: mkonicek
fb-gh-sync-id: f0761346b77060abf17f1d4573b375adebc5c607
shipit-source-id: f0761346b77060abf17f1d4573b375adebc5c607
rozele
referenced
this pull request
in microsoft/react-native-windows
May 25, 2016
Summary:Color property is ignored for TextInput with secureTextEntry={true} on Android.
This is coming from #6540 and being split into 2 PRs by suggestion of dmmiller.
As he mentioned does almost the same except it #6064 doesn't handle null case.
Working example:
Closes facebook/react-native#6563
Differential Revision: D3077583
Pulled By: mkonicek
fb-gh-sync-id: f0761346b77060abf17f1d4573b375adebc5c607
shipit-source-id: f0761346b77060abf17f1d4573b375adebc5c607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style properties fontFamily and color are ignored for TextInput with secureTextEntry={true} on Android.
Both issues are reported here:
secureTextEntryoff #5710Working example:
CC: @christopherdro