Use commander to parse command-line options #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it a bit more declarative/easier to add new commands and options to the command line.
|
react-native-cli is installed globally and therefore extremely hard to change. The goal for it is to do as few work as possible, and to forward all the commands to node_modules/react-native/cli.js which can be updated independently. If you want to add a build command, you should add it in cli.js. Hopefully if we've done our job correctly, we'll never update react-native-cli ever again. |
|
Ah! Sweet, I'll probably leave this for cli.js then. Thanks, will close/reopen against it. |
|
Updated in #651. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 28, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes #650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: Suppresses the unused warnings on ```YGDefaultLog```. It uses a more generic macro which simply casts the variable to ```(void)```. This is the simples approach to make mutiple different compilers happy. Fixes facebook#650 Closes facebook/yoga#651 Differential Revision: D6407999 Pulled By: emilsjolander fbshipit-source-id: 19fd78dd8b84eafdbb48875dd003d506a98c4807
jfrolich
added a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
* Press-event, href and target * Fix typo * Add react-native-web accessibility roles * also add web properties to touchables * use window scrolling * Update src/components/ScrollView.re Co-authored-by: Max Thirouin <git@moox.io>
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making it a bit more declarative/easier to add new commands and options to the command line.
Adding this as a foundation because I want to add more command line tooling like
react-native build.While in here, is there a reason I'm missing for the split between
react-native-cliandcli.js? Can we merge these?