unify use of password and secureTextEntry for TextInput#622
Closed
willpiers wants to merge 1 commit intofacebook:masterfrom
Closed
unify use of password and secureTextEntry for TextInput#622willpiers wants to merge 1 commit intofacebook:masterfrom
willpiers wants to merge 1 commit intofacebook:masterfrom
Conversation
|
👍 |
Contributor
Contributor
Author
Contributor
|
Many things here:
|
facebook-github-bot
added
the
CLA Signed
Collaborator
|
@vjeux - re: point 1, it is type="password" |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: Currently, the documentation shows both `password` and `secureTextEntry` as props for TextInput. However, the `password` prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers `password` over `secureTextEntry` but won't break anybody's code. Closes facebook#622 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: Currently, the documentation shows both `password` and `secureTextEntry` as props for TextInput. However, the `password` prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers `password` over `secureTextEntry` but won't break anybody's code. Closes facebook#622 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
This was referenced Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the documentation shows both
passwordandsecureTextEntryas props for TextInput. However, thepasswordprop is only passed to the Android component, so it does not work as expected for iOS developers. This PR preferspasswordoversecureTextEntrybut won't break anybody's code.