Skip set-rn-artifacts-version for PRs targeting stable branches#55809
Open
cipolleschi wants to merge 1 commit intomainfrom
Open
Skip set-rn-artifacts-version for PRs targeting stable branches#55809cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D94678295. |
cortinico
approved these changes
Feb 27, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
When a PR targets a -stable branch, github.ref_name is the PR branch (not ending in -stable), so the version script was incorrectly running. Added a check for github.base_ref to also skip the script when the PR target branch is a stable branch.
cipolleschi
force-pushed
the
cipolleschi/fix-android-template-helloworld-main
branch
from
eabd8cb to
53b28b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a PR targets a
-stablebranch,github.ref_nameis the PR branch (not ending in-stable), so the version script was incorrectly running. Added a check forgithub.base_refto also skip the script when the PR target branch is a stable branch.Changelog:
[Internal] - Skip set-rn-artifacts-version for PRs targeting stable branches
Test plan
CI should pass without running the artifacts version script on PRs targeting stable branches.