Fix silent tar extraction failure on EdenFS in replace-rncore-version#55797
Open
cipolleschi wants to merge 1 commit intomainfrom
Open
Fix silent tar extraction failure on EdenFS in replace-rncore-version#55797cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Extract tarball to a temporary directory on a regular filesystem first, then move results into the final location. This avoids EdenFS silently producing incomplete tar extractions. Also adds exit code checking and extraction verification. Adapted from D94625297 for the current main branch.
cipolleschi
force-pushed
the
cipolleschi/fix-replace-rncore-version-for-eden-main
branch
from
2dc7a3c to
ecaac38
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D94653392. |
cortinico
approved these changes
Feb 27, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On EdenFS,
tar -xfextraction directly into an EdenFS-mounted directory silently produces incomplete results — only the first slice of the tarball (ios-arm64) gets extracted, while the remaining entries (catalyst, simulator, top-level Headers) have their directories created but files are missing. Thereplace-rncore-version.jsscript didn't check tar's exit code, so it would write the config file and subsequent builds would skip re-extraction.This fix extracts the tarball to a temporary directory on a regular filesystem first, verifies the extraction succeeded (exit code + expected file check), then moves the results into the final location. This is adapted from D94625297 (which targeted 0.83) to work with the current main branch, preserving the v0.84 behavior of only deleting subdirectories in
React-Core-prebuilt(keeping files likeReact-VFS.yaml).Changelog:
[IOS] [FIXED] - Fix silent tar extraction failure on EdenFS in replace-rncore-version.js by extracting to a temp directory first
Test Plan:
Validated by the original patch author on EdenFS in D94625297. The logic is equivalent, adapted for the v0.84 code which preserves files in the target directory.