Skip to content

[0.83] Fix rncore tarball extraction for EdenFS compatibility#55795

Open
cipolleschi wants to merge 2 commits into0.83-stablefrom
cipolleschi/fix-replace-rncore-eden
Open

[0.83] Fix rncore tarball extraction for EdenFS compatibility#55795
cipolleschi wants to merge 2 commits into0.83-stablefrom
cipolleschi/fix-replace-rncore-eden

Conversation

@cipolleschi
Copy link
Contributor

Summary

  • Extract the rncore tarball to a temporary directory on a regular filesystem first, then move it to the final location
  • This avoids issues with partial tar extraction on EdenFS where extracting directly can silently produce incomplete results
  • Adds extraction verification (checks for expected xcframework structure) and mv/cp fallback logic

Changelog:

[Internal] - Fix rncore tarball extraction on EdenFS by extracting to a temp dir first and moving to final location

Test plan

  • Build an iOS app on EdenFS and verify that React-Core-prebuilt is correctly extracted
  • Verify the script still works on non-EdenFS filesystems

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2026
@github-actions
Copy link

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: BREAKING

@github-actions
Copy link

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@github-actions
Copy link

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@cortinico cortinico changed the title Fix rncore tarball extraction for EdenFS compatibility [0.83] Fix rncore tarball extraction for EdenFS compatibility Feb 27, 2026
@github-actions
Copy link

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@github-actions
Copy link

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

… compatibility

Extract the rncore tarball to a temporary directory on a regular filesystem
first, then move it to the final location. This avoids issues with partial
tar extraction on EdenFS where extracting directly can silently produce
incomplete results. Also adds extraction verification and mv/cp fallback logic.

## Changelog:
[Internal] - Fix rncore tarball extraction on EdenFS by extracting to a temp dir first and moving to final location
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-replace-rncore-eden branch from 5f16136 to 8cf2fa1 Compare February 27, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants