Skip to content

Improve bundling error message formatting #55794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenaic wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

Improve bundling error message formatting #55794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions private/react-native-fantom/runner/bundling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,19 @@ export async function createBundle(options: BundleOptions): Promise<void> {
);

if (lastBundleError || lastBundleResult?.ok !== true) {
throw new Error(
`Failed to request bundle from Metro: ${lastBundleError?.message ?? (await lastBundleResult?.text()) ?? ''}`,
);
let errorMessage =
lastBundleError?.message ?? (await lastBundleResult?.text()) ?? '';

try {
const parsed = JSON.parse(errorMessage);
if (typeof parsed.message === 'string') {
errorMessage = parsed.message;
}
} catch {
// Not JSON — use the raw text as-is.
}

throw new Error(`Failed to request bundle from Metro:\n${errorMessage}`);
}

await fs.promises.writeFile(
Expand Down
Loading