Delete deprecated CatalystInstanceImpl and C++ counterparts#55789
Open
mdvacca wants to merge 1 commit intofacebook:mainfrom
Open
Delete deprecated CatalystInstanceImpl and C++ counterparts#55789mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 27, 2026
…#55789) Summary: Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part of the Legacy Architecture cleanup. `CatalystInstanceImpl` was the bridge implementation for the old architecture. Its sole consumer, `ReactInstanceManager`, is itself deprecated — its constructor already throws `UnsupportedOperationException`. The `createReactContext` method that instantiated `CatalystInstanceImpl` has been stubbed to throw `UnsupportedOperationException` as well. Changes: - Deleted `CatalystInstanceImpl.java` (621 lines) - Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines) - Stubbed `ReactInstanceManager.createReactContext` to throw - Removed from BUCK and CMakeLists.txt build files - Removed from ReactAndroid.api public API surface - Removed from ReactNoNewJavaDetector Java allowlist - Removed from legacy architecture tracking script - Added direct `#include <cxxreact/MessageQueueThread.h>` to `JavaModuleWrapper.cpp` to replace transitive dependency Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl Reviewed By: javache Differential Revision: D94548637
mdvacca
force-pushed
the
export-D94548637
branch
from
40715b6 to
37288b7
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 27, 2026
…#55789) Summary: Pull Request resolved: facebook#55789 Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part of the Legacy Architecture cleanup. `CatalystInstanceImpl` was the bridge implementation for the old architecture. Its sole consumer, `ReactInstanceManager`, is itself deprecated — its constructor already throws `UnsupportedOperationException`. The `createReactContext` method that instantiated `CatalystInstanceImpl` has been stubbed to throw `UnsupportedOperationException` as well. Changes: - Deleted `CatalystInstanceImpl.java` (621 lines) - Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines) - Stubbed `ReactInstanceManager.createReactContext` to throw - Removed from BUCK and CMakeLists.txt build files - Removed from ReactAndroid.api public API surface - Removed from ReactNoNewJavaDetector Java allowlist - Removed from legacy architecture tracking script - Added direct `#include <cxxreact/MessageQueueThread.h>` to `JavaModuleWrapper.cpp` to replace transitive dependency Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl Reviewed By: javache Differential Revision: D94548637
mdvacca
force-pushed
the
export-D94548637
branch
from
37288b7 to
d28bc9a
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 27, 2026
…#55789) Summary: Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part of the Legacy Architecture cleanup. `CatalystInstanceImpl` was the bridge implementation for the old architecture. Its sole consumer, `ReactInstanceManager`, is itself deprecated — its constructor already throws `UnsupportedOperationException`. The `createReactContext` method that instantiated `CatalystInstanceImpl` has been stubbed to throw `UnsupportedOperationException` as well. Changes: - Deleted `CatalystInstanceImpl.java` (621 lines) - Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines) - Stubbed `ReactInstanceManager.createReactContext` to throw - Removed from BUCK and CMakeLists.txt build files - Removed from ReactAndroid.api public API surface - Removed from ReactNoNewJavaDetector Java allowlist - Removed from legacy architecture tracking script - Added direct `#include <cxxreact/MessageQueueThread.h>` to `JavaModuleWrapper.cpp` to replace transitive dependency Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl Reviewed By: javache Differential Revision: D94548637
mdvacca
force-pushed
the
export-D94548637
branch
from
d28bc9a to
d57b119
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 27, 2026
…#55789) Summary: Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part of the Legacy Architecture cleanup. `CatalystInstanceImpl` was the bridge implementation for the old architecture. Its sole consumer, `ReactInstanceManager`, is itself deprecated — its constructor already throws `UnsupportedOperationException`. The `createReactContext` method that instantiated `CatalystInstanceImpl` has been stubbed to throw `UnsupportedOperationException` as well. Changes: - Deleted `CatalystInstanceImpl.java` (621 lines) - Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines) - Stubbed `ReactInstanceManager.createReactContext` to throw - Removed from BUCK and CMakeLists.txt build files - Removed from ReactAndroid.api public API surface - Removed from ReactNoNewJavaDetector Java allowlist - Removed from legacy architecture tracking script - Added direct `#include <cxxreact/MessageQueueThread.h>` to `JavaModuleWrapper.cpp` to replace transitive dependency Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl Reviewed By: javache Differential Revision: D94548637
mdvacca
force-pushed
the
export-D94548637
branch
from
d57b119 to
5ee6616
Compare
…#55789) Summary: Pull Request resolved: facebook#55789 Removes the deprecated `CatalystInstanceImpl` class (Java) and its C++ JNI counterparts (`CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp`) as part of the Legacy Architecture cleanup. `CatalystInstanceImpl` was the bridge implementation for the old architecture. Its sole consumer, `ReactInstanceManager`, is itself deprecated — its constructor already throws `UnsupportedOperationException`. The `createReactContext` method that instantiated `CatalystInstanceImpl` has been stubbed to throw `UnsupportedOperationException` as well. Changes: - Deleted `CatalystInstanceImpl.java` (621 lines) - Deleted `CatalystInstanceImpl.h` and `CatalystInstanceImpl.cpp` (523 lines) - Stubbed `ReactInstanceManager.createReactContext` to throw - Removed from BUCK and CMakeLists.txt build files - Removed from ReactAndroid.api public API surface - Removed from ReactNoNewJavaDetector Java allowlist - Removed from legacy architecture tracking script - Added direct `#include <cxxreact/MessageQueueThread.h>` to `JavaModuleWrapper.cpp` to replace transitive dependency Changelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl Reviewed By: javache Differential Revision: D94548637
mdvacca
force-pushed
the
export-D94548637
branch
from
5ee6616 to
6a92fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the deprecated
CatalystInstanceImplclass (Java) and its C++ JNIcounterparts (
CatalystInstanceImpl.handCatalystInstanceImpl.cpp) as partof the Legacy Architecture cleanup.
CatalystInstanceImplwas the bridge implementation for the old architecture.Its sole consumer,
ReactInstanceManager, is itself deprecated — itsconstructor already throws
UnsupportedOperationException. ThecreateReactContextmethod that instantiatedCatalystInstanceImplhas beenstubbed to throw
UnsupportedOperationExceptionas well.Changes:
CatalystInstanceImpl.java(621 lines)CatalystInstanceImpl.handCatalystInstanceImpl.cpp(523 lines)ReactInstanceManager.createReactContextto throw#include <cxxreact/MessageQueueThread.h>toJavaModuleWrapper.cppto replace transitive dependencyChangelog: [Android][Removed] - Remove deprecated CatalystInstanceImpl
Differential Revision: D94548637