Fix parsing of Objective-C block properties#55776
Open
coado wants to merge 9 commits intofacebook:mainfrom
Open
Fix parsing of Objective-C block properties#55776coado wants to merge 9 commits intofacebook:mainfrom
coado wants to merge 9 commits intofacebook:mainfrom
Conversation
Differential Revision: D93859440
Differential Revision: D94071995
Differential Revision: D94072940
Differential Revision: D94076350
Summary: Doxygen adds spaces inside angle brackets in its XML output: - Outputs: `std::vector< PropNameID >` - Expected: `std::vector<PropNameID>` The solution is to apply `normalize_angle_brackets()` in `resolve_ref_text_name()` to normalize spacing consistently. Differential Revision: D94232505
Summary: Adding test for parsing interfaces with deprecated attributes and extending the doxygen test config with `__attribute__` predefined macro. ## Changelog: [Internal] Differential Revision: D94343118
Summary:
Doxygen incorrectly parses Objective-C interface declarations with protocol conformance. For example:
```objc
interface RCTAppearance : RCTEventEmitter <RCTBridgeModule>
```
Doxygen splits this into **two separate base classes** in the XML:
```xml
<basecompoundref>RCTEventEmitter</basecompoundref>
<basecompoundref><RCTBridgeModule></basecompoundref>
```
This caused the parser to output:
```
interface RCTAppearance : public RCTEventEmitter, public <RCTBridgeModule> {
```
Instead of the expected:
```
interface RCTAppearance : public RCTEventEmitter <RCTBridgeModule> {
```
The fix detects when a "base class" name starts and ends with `<...>` (indicating it's a protocol conformance) and combines it with the preceding actual base class name.
Differential Revision: D94351731
Summary: Doxygen splits block property types across `<type>` and `<argsstring>` elements. For example: ```objc property (nonatomic, copy) void (^eventInterceptor)(NSString *eventName, NSDictionary *event, NSNumber *reactTag); ``` Produces XML like: ```xml <type>void(^</type> <name>eventInterceptor</name> <argsstring>)(NSString *eventName, NSDictionary *event, NSNumber *reactTag)</argsstring> ``` This caused the parser to output incomplete types. The fix detects when the property type ends with `(^` and combines it with the property name and argsstring: ``` property (copy) void(^eventInterceptor)(NSString *eventName, NSDictionary *event, NSNumber *reactTag); ``` Reviewed By: cipolleschi Differential Revision: D94366205
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Doxygen splits block property types across
<type>and<argsstring>elements. For example:Produces XML like:
This caused the parser to output incomplete types. The fix detects when the property type ends with
(^and combines it with the property name and argsstring:Reviewed By: cipolleschi
Differential Revision: D94366205