fix(iOS): Add null check for fontName in RCTGetFontWeight to prevent crash#55414
Open
25harsh wants to merge 1 commit intofacebook:mainfrom
Open
fix(iOS): Add null check for fontName in RCTGetFontWeight to prevent crash#5541425harsh wants to merge 1 commit intofacebook:mainfrom
25harsh wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds defensive null check for
fontNameinRCTGetFontWeightbefore passing it toCFStringFind(), preventingEXC_BAD_ACCESScrash.Problem
RCTGetFontWeightpassesfont.fontNamedirectly toCFStringFind()without checking if the result is nil. Unlike Objective-C methods, Core Foundation functions likeCFStringFinddo not gracefully handle NULL pointers and willcrash with
EXC_BAD_ACCESS.While standard React Native apps typically register fonts at compile time. There are legitimate scenarios where fonts may not be immediately available. eg.
Brownfield applications - runtime font registration using
CTFontManagerRegisterGraphicsFont, this causes RN to crashChangelog:
[IOS][FIXED] - Added null check for fontName in RCTGetFontWeight to prevent crash
Test Plan:
When calling
RCTGetFontWeightwith nil UIFont (either empty string or unregistered font), no crash observed.