Skip to content

Prevent view collapsing when pointerEvents is 'box-only' #55185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziocucci wants to merge 2 commits into from
+8 −16
Closed

Prevent view collapsing when pointerEvents is 'box-only' #55185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef8464c
Make ImportantForInteractionHelper internal and move to views.view pa…
Jan 15, 2026
49f79ef
Prevent view collapsing when pointerEvents is 'box-only'
fabriziocucci Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3359,14 +3359,6 @@ public class com/facebook/react/uimanager/IllegalViewOperationException : com/fa
public final fun getView ()Landroid/view/View;
}

public final class com/facebook/react/uimanager/ImportantForInteractionHelper {
public static final field IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS I
public static final field IMPORTANT_FOR_INTERACTION_NO I
public static final field IMPORTANT_FOR_INTERACTION_YES I
public static final field INSTANCE Lcom/facebook/react/uimanager/ImportantForInteractionHelper;
public static final fun setImportantForInteraction (Landroid/view/View;Lcom/facebook/react/uimanager/PointerEvents;)V
}

public class com/facebook/react/uimanager/JSPointerDispatcher {
public fun <init> (Landroid/view/ViewGroup;)V
public fun handleMotionEvent (Landroid/view/MotionEvent;Lcom/facebook/react/uimanager/events/EventDispatcher;Z)V
Expand Down
13 changes: 7 additions & 6 deletions ...imanager/ImportantForInteractionHelper.kt → ...ews/view/ImportantForInteractionHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.uimanager
package com.facebook.react.views.view

import android.view.View
import com.facebook.react.R
import com.facebook.react.uimanager.PointerEvents

/**
* Helper class for managing the important_for_interaction view tag. This tag determines how a view
Expand All @@ -20,15 +21,15 @@ import com.facebook.react.R
* - [IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS]: Descendants should be excluded from
* interaction
*/
public object ImportantForInteractionHelper {
internal object ImportantForInteractionHelper {
/** The view is important for interaction. */
public const val IMPORTANT_FOR_INTERACTION_YES: Int = 0x1
const val IMPORTANT_FOR_INTERACTION_YES: Int = 0x1

/** The view is not important for interaction. */
public const val IMPORTANT_FOR_INTERACTION_NO: Int = 0x2
const val IMPORTANT_FOR_INTERACTION_NO: Int = 0x2

/** Descendants of this view should be excluded from interaction handling. */
public const val IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS: Int = 0x8
const val IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS: Int = 0x8

/**
* Sets the important_for_interaction tag on a view based on the given [PointerEvents] value.
Expand All @@ -45,7 +46,7 @@ public object ImportantForInteractionHelper {
* @param pointerEvents The pointer events value to convert and set
*/
@JvmStatic
public fun setImportantForInteraction(view: View, pointerEvents: PointerEvents) {
fun setImportantForInteraction(view: View, pointerEvents: PointerEvents) {
val value =
when (pointerEvents) {
PointerEvents.AUTO -> IMPORTANT_FOR_INTERACTION_YES
Expand Down
1 change: 0 additions & 1 deletion ...s/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import com.facebook.react.uimanager.BackgroundStyleApplicator.setBorderStyle
import com.facebook.react.uimanager.BackgroundStyleApplicator.setBorderWidth
import com.facebook.react.uimanager.BackgroundStyleApplicator.setFeedbackUnderlay
import com.facebook.react.uimanager.BlendModeHelper.needsIsolatedLayer
import com.facebook.react.uimanager.ImportantForInteractionHelper
import com.facebook.react.uimanager.LengthPercentage
import com.facebook.react.uimanager.LengthPercentageType
import com.facebook.react.uimanager.MeasureSpecAssertions.assertExplicitMeasureSpec
Expand Down
1 change: 0 additions & 1 deletion ...react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import com.facebook.react.common.ReactConstants
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.BackgroundStyleApplicator
import com.facebook.react.uimanager.ImportantForInteractionHelper
import com.facebook.react.uimanager.LengthPercentage
import com.facebook.react.uimanager.LengthPercentageType
import com.facebook.react.uimanager.PixelUtil.dpToPx
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ void ViewShadowNode::initialize() noexcept {
};

bool formsStackingContext = !viewProps.collapsable ||
viewProps.pointerEvents == PointerEventsMode::BoxOnly ||
viewProps.pointerEvents == PointerEventsMode::None ||
!viewProps.nativeId.empty() || viewProps.accessible ||
viewProps.opacity != 1.0 || viewProps.transform != Transform{} ||
Expand Down
Loading