Skip to content

Conversation

@tido64
Copy link
Collaborator

@tido64 tido64 commented Jan 7, 2026

Summary:

Syncs getAndroidResourceIdentifier implementations between /community-cli-plugin/src/commands/bundle/assetPathUtils.js and /assets/path-support.js.

Ideally, the former should use @react-native/assets-registry directly so we don't need to sync.

Changelog:

[ANDROID] [FIXED] - Handle unstable_path query param in asset URLs

Test Plan:

n/a

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 7, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 7, 2026

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D90267467.

@meta-codesync meta-codesync bot closed this in 42986f2 Jan 7, 2026
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 7, 2026
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @tido64 in 42986f2

When will my fix make it into a release? | How to file a pick request?

@meta-codesync
Copy link

meta-codesync bot commented Jan 7, 2026

@Abbondanzo merged this pull request in 42986f2.

@tido64 tido64 deleted the tido/community-cli-plugin/support-unstable_path branch January 8, 2026 09:48
react-native-bot pushed a commit that referenced this pull request Jan 12, 2026
Summary:
Syncs `getAndroidResourceIdentifier` implementations between [`/community-cli-plugin/src/commands/bundle/assetPathUtils.js`](https://github.com/facebook/react-native/blob/main/packages/community-cli-plugin/src/commands/bundle/assetPathUtils.js#L72-L79) and [`/assets/path-support.js`](https://github.com/facebook/react-native/blob/main/packages/assets/path-support.js#L77-L85).

Ideally, the former should use `react-native/assets-registry` directly so we don't need to sync.

## Changelog:

[ANDROID] [FIXED] - Handle `unstable_path` query param in asset URLs

Pull Request resolved: #55072

Test Plan: n/a

Reviewed By: javache

Differential Revision: D90267467

Pulled By: Abbondanzo

fbshipit-source-id: f4eb0053c6af02b67f3fb493ae76e290d6b354e5
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @tido64 in 41221b8

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants