Update EmbeddedApp.md #549
Conversation
L34~L39 <==> L126 should be same
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thanks, can you sign the CLA, rebase and i'll pull this in :) |
|
cla signed up. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -31,11 +31,11 @@ The installation process also requires [Node.js](http://nodejs.org). | |||
|
|
|||
| ## Create Your React Native App | |||
|
|
|||
| First, enter React Native's pod root directory and create **index.ios.js** inside a directory `ReactComponent`. | |||
| First, create a directory `ReactComponent`, enter the directory and create **index.ios.js** inside . | |||
There was a problem hiding this comment.
can you change index.ios.js to use backticks as well?
|
It has merge conflicts :( Can you rebase and i'll pull it in. Thanks! |
So Travis won't wipe out the website on error. :\
Die with status 1 when website generation fails
To catch docgen errors.
Build the website without publishing on PRs
Updates from Wed 1 Apr
L34~L39 <==> L126 should be same
… patch-1 Conflicts: docs/EmbeddedApp.md
L34~L39 <==> L126 should be same
|
I'm learning 'git rebase' via SourceTree.app ( #549 is my first rebase in my life, lol ) |
|
Didn't seem to work :( Maybe you want to abandon this one and recreate a new one with just your change? |
|
new one is #658 |
Remove unused line
* Verify that NuGet was actually created * minor fix * Forgot PR is happening on a unix box.. * syntax fix * use *nix seperator Co-authored-by: Andrew Coates <acoates-ms@noreply.github.com>
L34~L39 <==> L126 should be same