Skip to content

Promote Web Performance APIs to stable #54324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Promote Web Performance APIs to stable #54324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<346acf2190f419cc4de64f66cb40f802>>
* @generated SignedSource<<afccaed3066598724041c48bfb524234>>
*/

/**
Expand Down Expand Up @@ -125,7 +125,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enableVirtualViewWindowFocusDetection(): Boolean = false

override fun enableWebPerformanceAPIsByDefault(): Boolean = false
override fun enableWebPerformanceAPIsByDefault(): Boolean = true

override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = false

Expand Down
4 changes: 1 addition & 3 deletions ...book/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<4464982256b8ce543d9235fccbf67054>>
* @generated SignedSource<<f82b5905d822f8009c054a9443f86e39>>
*/

/**
Expand All @@ -27,8 +27,6 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android : ReactN

override fun enableFabricRenderer(): Boolean = true

override fun enableWebPerformanceAPIsByDefault(): Boolean = true

override fun useNativeViewConfigsInBridgelessMode(): Boolean = true

override fun useTurboModuleInterop(): Boolean = true
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d3786de5c8669d29376f135536f7cbbc>>
* @generated SignedSource<<d61394fb8056e5e1a68f9fe7b936985c>>
*/

/**
Expand Down Expand Up @@ -232,7 +232,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool enableWebPerformanceAPIsByDefault() override {
return false;
return true;
}

bool fixMappingOfEventPrioritiesBetweenFabricAndReact() override {
Expand Down
6 changes: 1 addition & 5 deletions ...s/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<32a03e199994c91c022013d7929bfea5>>
* @generated SignedSource<<db8626cf78a3ed226bbbe6bf20cc03a2>>
*/

/**
Expand Down Expand Up @@ -35,10 +35,6 @@ class ReactNativeFeatureFlagsOverridesOSSCanary : public ReactNativeFeatureFlags
return true;
}

bool enableWebPerformanceAPIsByDefault() override {
return true;
}

bool useNativeViewConfigsInBridgelessMode() override {
return true;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,14 +593,14 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
enableWebPerformanceAPIsByDefault: {
defaultValue: false,
defaultValue: true,
metadata: {
description:
'Enable Web Performance APIs (Performance Timeline, User Timings, etc.) by default.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'canary',
ossReleaseStage: 'stable',
},
fixMappingOfEventPrioritiesBetweenFabricAndReact: {
defaultValue: false,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<25169f72feeaa596faaeb8fc3fffac06>>
* @generated SignedSource<<7edda733c47c5e6db0287b8b6325cdfb>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -425,7 +425,7 @@ export const enableVirtualViewWindowFocusDetection: Getter<boolean> = createNati
/**
* Enable Web Performance APIs (Performance Timeline, User Timings, etc.) by default.
*/
export const enableWebPerformanceAPIsByDefault: Getter<boolean> = createNativeFlagGetter('enableWebPerformanceAPIsByDefault', false);
export const enableWebPerformanceAPIsByDefault: Getter<boolean> = createNativeFlagGetter('enableWebPerformanceAPIsByDefault', true);
/**
* Uses the default event priority instead of the discreet event priority by default when dispatching events from Fabric to React.
*/
Expand Down
Loading