Skip to content

Deprecate NetworkingModule.sendRequestInternal #54101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motiz88 wants to merge 1 commit into from
Closed

Deprecate NetworkingModule.sendRequestInternal #54101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion ...-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ public class NetworkingModule(
val requestId = requestIdAsDouble.toInt()
val timeout = timeoutAsDouble.toInt()
try {
sendRequestInternal(
sendRequestInternalReal(
method,
url,
requestId,
Expand All @@ -245,6 +245,7 @@ public class NetworkingModule(
}
}

@Deprecated("""sendRequestInternal is internal and will be made private in a future release.""")
/** @param timeout value of 0 results in no timeout */
public fun sendRequestInternal(
method: String,
Expand All @@ -256,6 +257,31 @@ public class NetworkingModule(
useIncrementalUpdates: Boolean,
timeout: Int,
withCredentials: Boolean,
) {
sendRequestInternalReal(
method,
url,
requestId,
headers,
data,
responseType,
useIncrementalUpdates,
timeout,
withCredentials,
)
}

/** @param timeout value of 0 results in no timeout */
private fun sendRequestInternalReal(
method: String,
url: String?,
requestId: Int,
headers: ReadableArray?,
data: ReadableMap?,
responseType: String,
useIncrementalUpdates: Boolean,
timeout: Int,
withCredentials: Boolean,
) {
val reactApplicationContext = getReactApplicationContextIfActiveOrWarn()
try {
Expand Down