Do not scroll to child inside nested scroll view#54044
Closed
rozele wants to merge 1 commit intofacebook:mainfrom
Closed
Do not scroll to child inside nested scroll view#54044rozele wants to merge 1 commit intofacebook:mainfrom
rozele wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Summary: In rare cases, there may be a vertical ScrollView nested inside another vertical ScrollView. In these cases, when the requestChildFocus method is called, we may attempt to bring the entire focused child into view. However, we really only want to bring the entire nested ScrollView into view. ## Changelog [Android][Fixed] Focused scroll into view behaviors for nested vertical scroll views Differential Revision: D83804043
rozele
force-pushed
the
export-D83804043
branch
from
c74b0a5 to
8509ea7
Compare
Contributor
|
This pull request has been merged in 26502c6. |
Collaborator
|
This pull request was successfully merged by @rozele in 26502c6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In rare cases, there may be a vertical ScrollView nested inside another vertical ScrollView. In these cases, when the requestChildFocus method is called, we may attempt to bring the entire focused child into view. However, we really only want to bring the entire nested ScrollView into view.
Changelog
[Android][Fixed] Focused scroll into view behaviors for nested vertical scroll views
Differential Revision: D83804043