Skip to content

Add toDynamic conversion for ValueUnit and ColorStop #54039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenaic wants to merge 1 commit into from
Closed

Add toDynamic conversion for ValueUnit and ColorStop #54039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/graphics/ColorStop.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ struct ColorStop {
bool operator==(const ColorStop& other) const = default;
SharedColor color;
ValueUnit position;

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const {
folly::dynamic result = folly::dynamic::object();
result["color"] = *color;
result["position"] = position.toDynamic();
return result;
}
#endif
};

struct ProcessedColorStop {
Expand Down
17 changes: 17 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/graphics/ValueUnit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

#pragma once

#ifdef RN_SERIALIZABLE_STATE
#include <folly/dynamic.h>
#endif

namespace facebook::react {

enum class UnitType {
Expand Down Expand Up @@ -44,5 +48,18 @@ struct ValueUnit {
constexpr operator bool() const {
return unit != UnitType::Undefined;
}

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic toDynamic() const {
switch (unit) {
case UnitType::Undefined:
return nullptr;
case UnitType::Point:
return value;
case UnitType::Percent:
return std::format("{}%", value);
}
}
#endif
};
} // namespace facebook::react
Loading