[ios][precompiled] add support for symbolication of precompiled React.xcframework #53976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for symbolication of the XCFrameworks on request. The reason doing this is that the symbol files are big and only needed if you need to debug React Native itself - f.ex. if you are a framework developer like Expo. Symbolication can be performed by setting the `RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS` environment variable to the value ''1'. This will cause the `ReactNativeCoreUtils` helper class to download symbol files and symbolicate the XFrameworks by doing the following: - After downloading the requested React.XCFramework the symbols will also be downloaded and places in the artifacts folder. - The XCFrameworks will be expanded and the folders in the symbol archive will be extracted into the XCFramework before it is zipped up again. Some additional parts of this refactoring: - Aligned logging in both rndependencies.rb and rncore.rb - Removed uneccessary logging - RNCore/Deps: Changed so that the source for the package is the locally downloaded file so we don't download twice!
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
cipolleschi
approved these changes
Sep 29, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
looks good on the surface. The PR is quite big, I'll start by importing it and then splitting it to analyze it better.
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D83481709. |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 2, 2025
Summary: This change remove some unnecessary logs and improve the logging functions for the prebuilds ## Changelog: [IOS] [CHANGED] - Updated logging functions for prebuilds Pull Request resolved: facebook#53976 Test Plan: Run: ``` RCT_USE_RN_DEP=1 RCT_USE_PREBUILT_RNCORE=1 bundle exec pod install ``` Differential Revision: D83481709 Pulled By: cipolleschi
Contributor
|
@cipolleschi merged this pull request in f0f8b95. |
Collaborator
|
This pull request was successfully merged by @chrfalch in f0f8b95 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds support for symbolication of the XCFrameworks on request.
The reason doing this is that the symbol files are big and only needed if you need to debug React Native itself - f.ex. if you are a framework developer like Expo.
Symbolication can be performed by setting the
RCT_SYMBOLICATE_PREBUILT_FRAMEWORKSenvironment variable to the value ''1'. This will cause theReactNativeCoreUtilshelper class to download symbol files and symbolicate the XFrameworks by doing the following:Some additional parts of this refactoring:
Changelog:
[IOS] [FIXED] - Added support for symbolication of precompiled React.xcframework
Test Plan:
Run pod install with the environment variable
RCT_SYMBOLICATE_PREBUILT_FRAMEWORKSset to '1'.Remember to clean (remove the Pods directory) before turning on/off.