Make codegen generate a Package.swift file for Codegen'd target #53619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81769543 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 5, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 5, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 8, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
force-pushed
the
export-D81769543
branch
from
2222106 to
2e6b66b
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81769543 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 9, 2025
…book#53619) Summary: Pull Request resolved: facebook#53619 With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Differential Revision: D81769543
cipolleschi
force-pushed
the
export-D81769543
branch
from
2e6b66b to
ad05d0a
Compare
cortinico
approved these changes
Sep 9, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…lder Summary: This change makes sure that we generate the codegen files in the ReactCodegen and ReactAppDependencyProvider folder. This is necessary as Swift PM needs the source code of packages to be grouped in folders that are children of where the Package.swift is located. This is not a breaking change, because Cocoapods has been updated accordingly, import/include paths are not changed and the folder layout should not be accessed by anybody directly ## Changelog: [Internal] - Differential Revision: D81769522
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
force-pushed
the
export-D81769543
branch
from
ad05d0a to
a557522
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
…book#53619) Summary: Pull Request resolved: facebook#53619 With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81769543 |
cipolleschi
force-pushed
the
export-D81769543
branch
from
a557522 to
d5adb80
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2025
…book#53619) Summary: With this change, we are making Codegen generate a Package.swift file so that we can integrate the `ReactCodegen` and the `ReactAppDependencyProvider` in apps only using SwiftPM ## Changelog [iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets Reviewed By: cortinico Differential Revision: D81769543
Contributor
|
This pull request has been merged in a7cd3cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With this change, we are making Codegen generate a Package.swift file so that we can integrate the
ReactCodegenand theReactAppDependencyProviderin apps only using SwiftPMChangelog
[iOS][Added] - Make codegen generate PAckage.swift file for the codegen targets
Differential Revision: D81769543