Skip to content

feat: background image native CSS parser #53609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
intergalacticspacehighway wants to merge 8 commits into from
Closed

feat: background image native CSS parser #53609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb16d45
add background image native parser
intergalacticspacehighway Sep 5, 2025
a4f55d4
remove semicolons from syntax
intergalacticspacehighway Sep 5, 2025
0418cdc
merge main
intergalacticspacehighway Sep 29, 2025
c1fd0dc
make parse functions private
intergalacticspacehighway Sep 30, 2025
605058b
pr feedback - return early
intergalacticspacehighway Sep 30, 2025
808221f
remove inline
intergalacticspacehighway Sep 30, 2025
eca725b
Merge branch 'main' into background-image-native-parsing
intergalacticspacehighway Oct 9, 2025
236922e
fix fantom test build
intergalacticspacehighway Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native/Libraries/Components/View/ReactNativeStyleAttributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ const ReactNativeStyleAttributes: {[string]: AnyAttributeType, ...} = {
/**
* Linear Gradient
*/
experimental_backgroundImage: {process: processBackgroundImage},

experimental_backgroundImage: ReactNativeFeatureFlags.enableNativeCSSParsing()
? true
: {process: processBackgroundImage},
/**
* View
*/
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ const validAttributesForNonEventProps = {
backgroundColor: {process: require('../StyleSheet/processColor').default},
transform: true,
transformOrigin: true,
experimental_backgroundImage: {
process: require('../StyleSheet/processBackgroundImage').default,
},
experimental_backgroundImage: ReactNativeFeatureFlags.enableNativeCSSParsing()
? (true as const)
: {process: require('../StyleSheet/processBackgroundImage').default},
boxShadow: ReactNativeFeatureFlags.enableNativeCSSParsing()
? (true as const)
: {process: require('../StyleSheet/processBoxShadow').default},
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native/React/Fabric/Utils/RCTGradientUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ @implementation RCTGradientUtils
+ (std::vector<ProcessedColorStop>)getFixedColorStops:(const std::vector<ColorStop> &)colorStops
gradientLineLength:(CGFloat)gradientLineLength
{
if (colorStops.empty()) {
return {};
}
Copy link
Contributor Author

@intergalacticspacehighway intergalacticspacehighway Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not trigger, but added this just in case!


std::vector<ProcessedColorStop> fixedColorStops(colorStops.size());
bool hasNullPositions = false;
auto maxPositionSoFar = resolveColorStopPosition(colorStops[0].position, gradientLineLength);
Expand Down
Loading
Loading