Fix/simplify invariant for ColorSchemeName, align manual typedef #53397
+16
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80705652 |
Collaborator
|
huntie
force-pushed
the
export-D80705652
branch
from
0fa272b to
f5f776e
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 26, 2025
…ebook#53397) Summary: This is a runtime behaviour fix and an API change to `Appearance.setColorScheme`, motivated by a user report where providing `'unspecified'` (valid) to this function would trigger an incorrect invariant throw. Furthermore, there is already a [first party use](https://github.com/facebook/react-native/blob/aec35b896053d9372ccdaf67c939b2eb216d3455/packages/react-native/Libraries/Utilities/Appearance.js#L101) where we call `Appearance.setColorScheme('unspecified')`. **Changes** - `Appearance.d.ts` (current public API, manual types): Fix `ColorSchemeName` type to include `'unspecified'` value, and narrow to remove nullability — aligning with existing Flow source for this type in `NativeAppearance`. - `Appearance.js` (implementation): Fix the invariant throw by **removing it**, and instead narrowing the input type to non-nullable. Redundant work in `getState` and `getColorScheme` is removed. Changelog: [General][Breaking] `Appearance.setColorScheme` no longer accepts a nullable value Differential Revision: D80705652
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80705652 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 29, 2025
…ebook#53397) Summary: This is a runtime behaviour fix and an API change to `Appearance.setColorScheme`, motivated by a user report where providing `'unspecified'` (valid) to this function would trigger an incorrect invariant throw. Furthermore, there is already a [first party use](https://github.com/facebook/react-native/blob/aec35b896053d9372ccdaf67c939b2eb216d3455/packages/react-native/Libraries/Utilities/Appearance.js#L101) where we call `Appearance.setColorScheme('unspecified')`. **Changes** - `Appearance.d.ts` (current public API, manual types): Fix `ColorSchemeName` type to include `'unspecified'` value, and narrow to remove nullability — aligning with existing Flow source for this type in `NativeAppearance`. - `Appearance.js` (implementation): Fix the invariant throw by **removing it**, and instead narrowing the input type to non-nullable. Redundant work in `getState` and `getColorScheme` is removed. Changelog: [General][Breaking] `Appearance.setColorScheme` no longer accepts a nullable value Reviewed By: andrewdacenko Differential Revision: D80705652
huntie
force-pushed
the
export-D80705652
branch
from
f5f776e to
c5bd7f7
Compare
…ebook#53397) Summary: Pull Request resolved: facebook#53397 This is a runtime behaviour fix and an API change to `Appearance.setColorScheme`, motivated by a user report where providing `'unspecified'` (valid) to this function would trigger an incorrect invariant throw. Furthermore, there is already a [first party use](https://github.com/facebook/react-native/blob/aec35b896053d9372ccdaf67c939b2eb216d3455/packages/react-native/Libraries/Utilities/Appearance.js#L101) where we call `Appearance.setColorScheme('unspecified')`. **Changes** - `Appearance.d.ts` (current public API, manual types): Fix `ColorSchemeName` type to include `'unspecified'` value, and narrow to remove nullability — aligning with existing Flow source for this type in `NativeAppearance`. - `Appearance.js` (implementation): Fix the invariant throw by **removing it**, and instead narrowing the input type to non-nullable. Redundant work in `getState` and `getColorScheme` is removed. Changelog: [General][Breaking] `Appearance.setColorScheme` no longer accepts a nullable value Reviewed By: andrewdacenko Differential Revision: D80705652
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80705652 |
huntie
force-pushed
the
export-D80705652
branch
from
c5bd7f7 to
f178018
Compare
Contributor
|
This pull request has been merged in a4581ec. |
Collaborator
|
This pull request was successfully merged by @huntie in a4581ec When will my fix make it into a release? | How to file a pick request? |
huntie
added
the
JS API refinements (2025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a runtime behaviour fix and an API change to
Appearance.setColorScheme, motivated by a user report where providing'unspecified'(valid) to this function would trigger an incorrect invariant throw. Furthermore, there is already a first party use where we callAppearance.setColorScheme('unspecified').Changes
Appearance.d.ts(current public API, manual types): FixColorSchemeNametype to include'unspecified'value, and narrow to remove nullability — aligning with existing Flow source for this type inNativeAppearance.Appearance.js(implementation): Fix the invariant throw by removing it, and instead narrowing the input type to non-nullable. Redundant work ingetStateandgetColorSchemeis removed.Changelog: [General][Breaking]
Appearance.setColorSchemeno longer accepts a nullable valueDifferential Revision: D80705652