expose HMRClient for use in Expo #53081
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While upgrading Expo to the latest React Native, we're seeing a number of warnings from internal imports. We've been able to work around most of these expo/expo#38587 expo/expo#38588 expo/expo#38495 but some are harder to work around.
This PR exposes HMRClient module which we use for async bundle loading. While there is an new upstream version of
__loadBundleAsync, it isn't enabled in production and doesn't give us the flexibility to send headers back to the server (which we use for React Server Components on native).Changelog:
[GENERAL] [ADDED] - Export HMRClient from react-native.
Test Plan: