Clean up feature flag preventShadowTreeCommitExhaustionWithLocking #52791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [internal] This cleans up this feature flag as it doesn't work as intended. We'll try another approach with a different flag instead. Differential Revision: D78815892
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78815892 |
Contributor
|
This pull request has been merged in c6c7c37. |
Collaborator
|
This pull request was successfully merged by @rubennorte in c6c7c37 When will my fix make it into a release? | How to file a pick request? |
cortinico
pushed a commit
that referenced
this pull request
Jul 28, 2025
…52791) Summary: Pull Request resolved: #52791 Changelog: [internal] This cleans up this feature flag as it doesn't work as intended. We'll try another approach with a different flag instead. Reviewed By: sammy-SC Differential Revision: D78815892 fbshipit-source-id: 4c651a3a225de9cfb54d00346343c7f2e3bea1d5
Collaborator
|
This pull request was successfully merged by @rubennorte in 255bf8b When will my fix make it into a release? | How to file a pick request? |
motiz88
pushed a commit
that referenced
this pull request
Jul 28, 2025
…king (#52862) * Clean up feature flag preventShadowTreeCommitExhaustionWithLocking (#52791) Summary: Pull Request resolved: #52791 Changelog: [internal] This cleans up this feature flag as it doesn't work as intended. We'll try another approach with a different flag instead. Reviewed By: sammy-SC Differential Revision: D78815892 fbshipit-source-id: 4c651a3a225de9cfb54d00346343c7f2e3bea1d5 * Implement solution for ShadowTree commmit exhaustion using recursive locks (behind a flag) (#52795) Summary: Pull Request resolved: #52795 Changelog: [internal] This is another attempt to fix #51870, inspired by #52314 but gated behind a feature flag until we've tested it carefully. Reviewed By: sammy-SC Differential Revision: D78817100 fbshipit-source-id: 45e6cae019b212528f2b2e74b9f52fe43d07f537 * [LOCAL] Correctly sort preventShadowTreeCommitExhaustion after merge conflict --------- Co-authored-by: Rubén Norte <rubennorte@meta.com>
Collaborator
|
This pull request was successfully merged by @cortinico in cb20a1c When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
…acebook#52791) Summary: Pull Request resolved: facebook#52791 Changelog: [internal] This cleans up this feature flag as it doesn't work as intended. We'll try another approach with a different flag instead. Reviewed By: sammy-SC Differential Revision: D78815892 fbshipit-source-id: 4c651a3a225de9cfb54d00346343c7f2e3bea1d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This cleans up this feature flag as it doesn't work as intended. We'll try another approach with a different flag instead.
Differential Revision: D78815892