Fix RNTester system bars background when edge-to-edge is enforced #51929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zoontek
changed the title
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
alanleedev
reviewed
Jun 11, 2025
packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt
Outdated
Show resolved
Hide resolved
alanleedev
reviewed
Jun 11, 2025
packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt
Show resolved
Hide resolved
packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt
Outdated
Show resolved
Hide resolved
zoontek
force-pushed
the
fix-system-bars-background-edge-to-edge
branch
2 times, most recently
from
d239ad6 to
2005481
Compare
zoontek
force-pushed
the
fix-system-bars-background-edge-to-edge
branch
from
168175c to
f9615cd
Compare
Contributor
Author
|
@alanleedev Updated it, it doesn't depends on #51925 anymore. |
alanleedev
reviewed
Jun 13, 2025
| resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK == | ||
| Configuration.UI_MODE_NIGHT_YES | ||
|
|
||
| val color = if (isDarkMode) "#0b0600" else "#f3f8ff" |
Contributor
There was a problem hiding this comment.
Can we use int constructor instead of converting from hex string which doesn't require conversion?
true -> Color.rgb(11, 6, 0),
false -> Color.rgb(243, 248, 255),
Contributor
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@alanleedev merged this pull request in b5be57c. |
Collaborator
|
This pull request was successfully merged by @zoontek in b5be57c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes RNTester system bars background color to match the app one (not solid black).
Changelog:
Test Plan:
demo.mp4