[RN][iOS][0.76] Bump folly to fix xcode 16.3 removed traits #50431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
changed the title
cortinico
approved these changes
Apr 1, 2025
Comment on lines
10
to
-18
| spec.name = "fmt" | ||
| spec.version = "9.1.0" | ||
| spec.version = "11.0.2" | ||
| spec.license = { :type => "MIT" } | ||
| spec.homepage = "https://github.com/fmtlib/fmt" | ||
| spec.summary = "{fmt} is an open-source formatting library for C++. It can be used as a safe and fast alternative to (s)printf and iostreams." | ||
| spec.authors = "The fmt contributors" | ||
| spec.source = { | ||
| :git => fmt_git_url, | ||
| :tag => "9.1.0" |
Contributor
There was a problem hiding this comment.
@cipolleschi Are we bumping FMT also? If so this needs to be mentioned in changelog
Contributor
Author
There was a problem hiding this comment.
yes, it is required by folly.
| fast_float_git_url = fast_float_config[:git] | ||
|
|
||
| Pod::Spec.new do |spec| | ||
| spec.name = "fast_float" |
Contributor
There was a problem hiding this comment.
also this needs to be called out in the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Xcode 16.3 removes the base template for std::char_traits: developer.apple.com/documentation/xcode-release-notes/xcode-16_3-release-notes
Changelog:
[iOS][Changed] - Bumped folly to fix Xcode 16.3
Test Plan:
Tested that RNTester builds for both iOS and Android with this PR.