Split out CdpJson into separate library #50170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71551561 |
|
This pull request was exported from Phabricator. Differential Revision: D71551561 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: facebook#50170 This is needed in D71470038 and later, where submodules of `jsinspector-modern` need to operate with CDP message payloads. We functionally split out these files as a library to avaoid a dependency cycle. Changelog: [Internal] Differential Revision: D71551561
huntie
force-pushed
the
export-D71551561
branch
from
4468718 to
f5ec39c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71551561 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: facebook#50170 This is needed in D71470038 and later, where submodules of `jsinspector-modern` need to operate with CDP message payloads. We functionally split out these files as a library to avaoid a dependency cycle. Changelog: [Internal] Differential Revision: D71551561
huntie
force-pushed
the
export-D71551561
branch
from
f5ec39c to
6d9a235
Compare
Summary: Pull Request resolved: facebook#50170 This is needed in D71470038 and later, where submodules of `jsinspector-modern` need to operate with CDP message payloads. We functionally split out these files as a library to avaoid a dependency cycle. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D71551561
|
This pull request was exported from Phabricator. Differential Revision: D71551561 |
huntie
force-pushed
the
export-D71551561
branch
from
6d9a235 to
299a541
Compare
|
This pull request has been merged in 094a22f. |
|
This pull request was successfully merged by @huntie in 094a22f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is needed in D71470038 and later, where submodules of
jsinspector-modernneed to operate with CDP message payloads. We functionally split out these files as a library to avaoid a dependency cycle.Changelog: [Internal]
Differential Revision: D71551561