[LOCAL][RN][iOS][OldArch] Add missing loadFromSource method in the DefaultRNFactoryDelegate #49930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/fix-old-arch-template
branch
2 times, most recently
from
e724974 to
7866529
Compare
…faultRNFactoryDelegate
cipolleschi
force-pushed
the
cipolleschi/fix-old-arch-template
branch
from
7866529 to
2481685
Compare
cortinico
approved these changes
Mar 10, 2025
|
Would it be possible to have this commit also merged into a new 0.78.x patch release? It appears to be missing from 0.78.1 causing a lot of issues for those who are still on the old architecture. |
|
We already have a pick request for it: reactwg/react-native-releases#873 |
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change fixes the app startup in the Old Architecture by implementing the
loadSourceForBridge:onProgress:onCompletemethod in theRCTDefaultReactNativeFactoryDelegateobject.The method was missing here, so the Bridge was never trying to load the JS bundle from Metro, resulting in an empty app.
Changelog:
[iOS][Fixed] - Implement the
loadSourceForBridge:onProgress:onCompletein theRCTDefaultReactNativeFactoryDelegate.Test Plan:
Tested locally in RNTester by removing the method in the AppDelegate (the app was loading blank) and then moving it into the
RCTDefaultReactNativeFactoryDelegate(the app was loading again).I also tested it in a new RN App from the template, built starting from 0.79.0-rc.0