-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build
function to the prepare-ios-script
#49363
Closed
Closed
+231
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D69533218 |
Summary: This diff adds a script in the `react-native/script/releases` folder that we will use as base to prepare prebuilds for iOS The script can be invoked from the repository root with ``` node scripts/releases/prepare-ios-prebuilds.js ``` ## Changelog: [Internal] - Add scripts to prepare ios prebuilds Reviewed By: cortinico Differential Revision: D69461691
Summary: This change adds a function in the prebuild script to download a 3p dependency in the react native monorepo. ## Changelog: [Internal] - Add function to download 3rd party dependencies Reviewed By: cortinico Differential Revision: D69464429
Summary: This change adds the step to download the glog dependency and run the prepare_glog script that we have in the codebase ## Changelog: [Internal] - Download Glog and patch it. Reviewed By: cortinico Differential Revision: D69466238
…book#49360) Summary: We don't need the whole dependencies archiveto build the dependencies. But usually we only need a subset of them. This change add a functionality to the script to remove the unnecessary files. ## Changelog: [Internal] - Add feature to remove unnecessary files from 3p dependencies. Differential Revision: D69518656
…#49361) Summary: This change adds the Package.swift file that we will use to build the dependencies for React Native ## Changelog: [Internal] - Swift PM file to build ReactNativeDependencies Differential Revision: D69518776
Summary: This change adds the `build()` function that calls xcodebuild to prepare the ReactNativeDependencies.framework This functio creates the frameworks in the /react-native/third-party/.build folder ## Changelog: [Internal] - Add build folder to the `prepare-ios-script` Differential Revision: D69533218
e4441c0
to
f74cbc4
Compare
This pull request was exported from Phabricator. Differential Revision: D69533218 |
This pull request has been merged in dd0e1f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds the
build()
function that calls xcodebuild to prepare the ReactNativeDependencies.frameworkThis functio creates the frameworks in the /react-native/third-party/.build folder
Changelog:
[Internal] - Add build folder to the
prepare-ios-script
Differential Revision: D69533218
Test Plan:
Tested on an example project.
To test it:
.build/Build/Products/Debug-iphonesimulator/PackageFrameworks/ReactNativeDependencies.framework
file and copy it to the app folderReactNativeDependencies.framework
, create aHeaders/glog
folderHeaders/glog
folderFrameworks, Libraries and Embedded Content
section of a test appReactNativeDependencies.framework
line to the App's Header Search Path.