Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build function to the prepare-ios-script #49363

Closed
wants to merge 6 commits into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Feb 12, 2025

Summary:
This change adds the build() function that calls xcodebuild to prepare the ReactNativeDependencies.framework

This functio creates the frameworks in the /react-native/third-party/.build folder

Changelog:

[Internal] - Add build folder to the prepare-ios-script

Differential Revision: D69533218

Test Plan:

Tested on an example project.

To test it:

  • took the .build/Build/Products/Debug-iphonesimulator/PackageFrameworks/ReactNativeDependencies.framework file and copy it to the app folder
  • in the ReactNativeDependencies.framework, create a Headers/glog folder
  • Copy all the headers from the glog folder into the Headers/glog folder
  • Drag and drop the framework in the Frameworks, Libraries and Embedded Content section of a test app
Screenshot 2025-02-12 at 17 29 41
  • Add the ReactNativeDependencies.framework line to the App's Header Search Path.
Screenshot 2025-02-12 at 17 30 05
  • Build and Run
Screenshot 2025-02-12 at 17 29 16

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69533218

Summary:

This diff adds a script in the `react-native/script/releases` folder that we will use as base to prepare prebuilds for iOS

The script can be invoked from the repository root with
```
node scripts/releases/prepare-ios-prebuilds.js
```

## Changelog:
[Internal] - Add scripts to prepare ios prebuilds

Reviewed By: cortinico

Differential Revision: D69461691
Summary:

This change adds a function in the prebuild script to download a 3p dependency in the react native monorepo.

## Changelog:
[Internal] - Add function to download 3rd party dependencies

Reviewed By: cortinico

Differential Revision: D69464429
Summary:

This change adds the step to download the glog dependency and run the prepare_glog script that we have in the codebase

## Changelog:
[Internal] - Download Glog and patch it.

Reviewed By: cortinico

Differential Revision: D69466238
…book#49360)

Summary:

We don't need the whole dependencies archiveto build the dependencies. But usually we only need a subset of them.

This change add a functionality to the script to remove the unnecessary files.

## Changelog:
[Internal] - Add feature to remove unnecessary files from 3p dependencies.

Differential Revision: D69518656
…#49361)

Summary:

This change adds the Package.swift file that we will use to build the dependencies for React Native

## Changelog:
[Internal] - Swift PM file to build ReactNativeDependencies

Differential Revision: D69518776
Summary:

This change adds the `build()` function that calls xcodebuild to prepare the ReactNativeDependencies.framework

This functio creates the frameworks in the /react-native/third-party/.build folder

## Changelog:
[Internal] - Add build folder to the `prepare-ios-script`

Differential Revision: D69533218
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69533218

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 13, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in dd0e1f2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants