Allow UnsafeMixed as Array value in codegen #49324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69454101 |
Summary: Provide Android component codegen a bit more flexibility by allowing `$ReadOnlyArray<UnsafeMixed>` and avoid casting in the view manager. Changelog: [General][Added] Reviewed By: fabriziocucci Differential Revision: D69454101
javache
force-pushed
the
export-D69454101
branch
from
9646b82 to
a20308f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69454101 |
|
This pull request has been merged in abd7259. |
|
This pull request was successfully merged by @javache in abd7259 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Provide Android component codegen a bit more flexibility by allowing
$ReadOnlyArray<UnsafeMixed>and avoid casting in the view manager.Changelog: [General][Added] Support
$ReadOnlyArray<UnsafeMixed>in react-native-codegenDifferential Revision: D69454101