CMake "react_render_" to "react_renderer_" #49284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69338892 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69338892 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 8, 2025
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Differential Revision: D69338892
NickGerleman
force-pushed
the
export-D69338892
branch
from
7ec2ae1 to
58ff4ff
Compare
Summary: Add a flag which we will use to prefer Fabric CSS parser to ViewConfig processors. We will use this to experiment on iOS, where we are using Fabric props (until Props 2.0 for Android). Changelog: [Internal] Differential Revision: D69337803
…rsing()` Summary: When the flag is enabled, we expect legacy native viewconfigs to add processor, where SVCs do not, and instead parse in native. Don't emit warnings in this case. Changelog: [Internal] Differential Revision: D69337802
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69338892 |
NickGerleman
force-pushed
the
export-D69338892
branch
from
58ff4ff to
0421aa2
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 10, 2025
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D69338892
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69338892 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 10, 2025
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D69338892
NickGerleman
force-pushed
the
export-D69338892
branch
from
0421aa2 to
e90f2a7
Compare
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D69338892
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69338892 |
NickGerleman
force-pushed
the
export-D69338892
branch
from
e90f2a7 to
8136bd9
Compare
Contributor
|
This pull request has been merged in 75edf3a. |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D69338892 fbshipit-source-id: d3b306ad0ea191728dfbacf9e2aaa12b00caa619
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#49284 All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name. eye_twitch I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D69338892 fbshipit-source-id: d3b306ad0ea191728dfbacf9e2aaa12b00caa619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All of the CMake library names in the "renderer" directory use "render" for the name, missing the last two letters of the directory name.
eye_twitch
I don't think fixing that should be breaking, since 3p libraries need to rely on the merged library anyway, so let's fix that and find/replace all these.
Changelog: [Internal]
Differential Revision: D69338892