Animated: Setup scheduleAnimatedCleanupInMicrotask Feature Flag
#48878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68527096 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jan 23, 2025
…cebook#48878) Summary: Creates a new `scheduleAnimatedCleanupInMicrotask` feature flag to experiment with deferring the `AnimatedProps` cleanup using the microtask queue. This is different from the previous approach of deferring invocation of the completion callback, which impacted the timing of composite animations such as `Animated.parallel` and `Animated.sequence`, because we are deferring detaching the `AnimatedNode` graph instead. This will only impact the timing of completion callbacks as a result of invalidating `AnimatedProps` (either by passing in new `AnimatedValue` instances or unmounting the component). This should minimally impact scheduling and have lower risk of user-visible behavior change because React already provides minimal guarantees around when updates are committed (and effects attached/detached). This also enables us to significantly simplify the current convoluted dance we do to optimized around reference counting in the AnimatedNode graph. Changelog: [General][Changed] - When an Animated component is updated or unmounted, `AnimatedNode` instances will now detach in a microtask instead of synchronously in the commit phase of React. This will cause the completion callback of finished animations to execute after the commit phase instead of during it. Differential Revision: D68527096
yungsters
force-pushed
the
export-D68527096
branch
from
e29ce1b to
5f23d95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68527096 |
…cebook#48878) Summary: Pull Request resolved: facebook#48878 Creates a new `scheduleAnimatedCleanupInMicrotask` feature flag to experiment with deferring the `AnimatedProps` cleanup using the microtask queue. This is different from the previous approach of deferring invocation of the completion callback, which impacted the timing of composite animations such as `Animated.parallel` and `Animated.sequence`, because we are deferring detaching the `AnimatedNode` graph instead. This will only impact the timing of completion callbacks as a result of invalidating `AnimatedProps` (either by passing in new `AnimatedValue` instances or unmounting the component). This should minimally impact scheduling and have lower risk of user-visible behavior change because React already provides minimal guarantees around when updates are committed (and effects attached/detached). This also enables us to significantly simplify the current convoluted dance we do to optimized around reference counting in the AnimatedNode graph. Changelog: [General][Changed] - When an Animated component is updated or unmounted, `AnimatedNode` instances will now detach in a microtask instead of synchronously in the commit phase of React. This will cause the completion callback of finished animations to execute after the commit phase instead of during it. Reviewed By: rickhanlonii Differential Revision: D68527096
yungsters
force-pushed
the
export-D68527096
branch
from
5f23d95 to
0b27c08
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68527096 |
|
This pull request has been merged in 50b75a7. |
|
This pull request was successfully merged by @yungsters in 50b75a7 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Creates a new
scheduleAnimatedCleanupInMicrotaskfeature flag to experiment with deferring theAnimatedPropscleanup using the microtask queue.This is different from the previous approach of deferring invocation of the completion callback, which impacted the timing of composite animations such as
Animated.parallelandAnimated.sequence, because we are deferring detaching theAnimatedNodegraph instead. This will only impact the timing of completion callbacks as a result of invalidatingAnimatedProps(either by passing in newAnimatedValueinstances or unmounting the component).This should minimally impact scheduling and have lower risk of user-visible behavior change because React already provides minimal guarantees around when updates are committed (and effects attached/detached).
This also enables us to significantly simplify the current convoluted dance we do to optimized around reference counting in the AnimatedNode graph.
Changelog:
[General][Changed] - When an Animated component is updated or unmounted,
AnimatedNodeinstances will now detach in a microtask instead of synchronously in the commit phase of React. This will cause the completion callback of finished animations to execute after the commit phase instead of during it.Differential Revision: D68527096