Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.ts #48876

Closed
wants to merge 1 commit into from
Closed

Update info.ts #48876

wants to merge 1 commit into from

Conversation

riteshshukla04
Copy link
Contributor

Summary:

Found this while I was trying to make my own react native info for CI. For android Podfile.lock is being read instead of gradle.properties

Changelog:

Test Plan:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 22, 2025
@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented Jan 22, 2025

@cortinico Can you please check this? . I stumbled upon this while I was trying to fiddle around with React native info .Not sure if this is even being used somewhere

@cortinico
Copy link
Contributor

@cortinico Can you please check this? . I stumbled upon this while I was trying to fiddle around with React native info .Not sure if this is even being used somewhere

The code of react-native info is here though: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/src/commands/info.ts

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@riteshshukla04
Copy link
Contributor Author

Thanks for the approval @cortinico . Can you please merge this

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 23, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 317f130.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @riteshshukla04 in 317f130

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants