Fix ruby unit tests #48498
Closed
Fix ruby unit tests #48498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
kraenhansen
commented
Jan 5, 2025
| @@ -513,9 +513,10 @@ def get_podspec_no_fabric_no_script | |||
| 'source' => { :git => '' }, | |||
| 'header_mappings_dir' => './', | |||
| 'platforms' => { | |||
| :ios => '13.4', | |||
| :ios => '15.1', | |||
There was a problem hiding this comment.
This was updated since the tests ran last: #46137
kraenhansen
commented
Jan 5, 2025
Comment on lines
-14
to
-16
| def get_folly_config() | ||
| return Helpers::Constants.folly_config | ||
| end |
There was a problem hiding this comment.
No longer needed now that the Helpers are accessed directly.
kraenhansen
commented
Jan 5, 2025
Comment on lines
+535
to
+544
| 'OTHER_CPLUSPLUSFLAGS' => [ | ||
| '$(inherited)', | ||
| '-DFOLLY_NO_CONFIG', | ||
| '-DFOLLY_MOBILE=1', | ||
| '-DFOLLY_USE_LIBCPP=1', | ||
| '-DFOLLY_CFG_NO_COROUTINES=1', | ||
| '-DFOLLY_HAVE_CLOCK_GETTIME=1', | ||
| '-Wno-comma', | ||
| '-Wno-shorten-64-to-32', | ||
| '-Wno-documentation' |
kraenhansen
commented
Jan 5, 2025
| @@ -544,6 +556,7 @@ def get_podspec_no_fabric_no_script | |||
| "ReactCommon/turbomodule/core": [], | |||
| "hermes-engine": [], | |||
| "React-NativeModulesApple": [], | |||
| 'React-RCTAppDelegate': [], | |||
kraenhansen
commented
Jan 5, 2025
| }, | ||
| 'source_files' => "**/*.{h,mm,cpp}", | ||
| 'exclude_files' => "RCTAppDependencyProvider.{h,mm}", |
cipolleschi
approved these changes
Jan 6, 2025
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 7a85b91. |
|
This pull request was successfully merged by @kraenhansen in 7a85b91 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As a prerequisite of enabling running unit tests on CI again, this PR suggests changes needed to the Ruby unit tests.
I've added comments on the code below, justifying changes where I deem a justification might be needed.
For use internally, I suggest accessing the folly_config and boost_config directly via the
Helpersclass instead of theget_folly_configandget_boost_configbecause these global functions are defined inreact_native_pods.rband requiring that file would be result in circular requires. An alternative would be to move these global functions to a separate file.Changelog:
[INTERNAL] [FIXED] - Fix Ruby unit tests.
Test Plan:
cd packages/react-native./scripts/run_ruby_tests.sh