Introduce Android ImageManger #47721
Closed
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
0536973 to
7cb8717
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
7cb8717 to
f2783ed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
f2783ed to
f2e3fcc
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 23, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
f2e3fcc to
820edf7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
820edf7 to
562cd59
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
562cd59 to
24c6c06
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
24c6c06 to
d1ace70
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 26, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 26, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Contributor
|
This pull request has been merged in a6b2355. |
Collaborator
|
This pull request was successfully merged by @dmytrorykun in a6b2355 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as
RCTImageManager.mmfor iOS.Changelog: [Internal]
Differential Revision: D65753319