fix Modal content being cut off when Activity is edge-to-edge #47339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65280014 |
|
Testing with ReproducerApp API29 API34 |
alanleedev
force-pushed
the
export-D65280014
branch
from
2fe8c0e
to
2035cd4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65280014 |
…facebook#47339) Summary: Fixing issue raised in facebook#47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Reviewed By: cortinico Differential Revision: D65280014
alanleedev
force-pushed
the
export-D65280014
branch
from
2035cd4
to
2fa5b89
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65280014 |
|
This pull request has been merged in 2cd48ef. |
|
This pull request was successfully merged by @alanleedev in 2cd48ef When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Nov 12, 2024
…#47339) Summary: Pull Request resolved: #47339 Fixing issue raised in #47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Reviewed By: cortinico Differential Revision: D65280014 fbshipit-source-id: 616ff739be55635f1295ef3bf8b997a27ef769ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing issue raised in #47307
This is a follow up from D62286026.
It appears there was a line that went missing while trying to refactor the code.
fitsSystemWindows = trueis needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge.Differential Revision: D65280014