Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] automaticallyAdjustKeyboardInsets not shifting scrollview content #46732

Closed
wants to merge 7 commits into from
+30 −13
Closed

[iOS] automaticallyAdjustKeyboardInsets not shifting scrollview content #46732

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b16270
[iOS] automaticallyAdjustKeyboardInsets not shifting scrollview content
zhongwuzw Sep 27, 2024
f196483
Fixes textinput not in accessory view
zhongwuzw Sep 29, 2024
60fb645
Add missing break statement
zhongwuzw Sep 30, 2024
cd12132
Change way of find first responder
zhongwuzw Sep 30, 2024
cbe920b
Opt code
zhongwuzw Oct 2, 2024
1c4cd4f
Merge commit '4076dbfc8651fcd193b886bf63b23728fad466d7' into features…
zhongwuzw Oct 29, 2024
062b735
Update
zhongwuzw Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing break statement
  • Loading branch information
@zhongwuzw
zhongwuzw committed Sep 30, 2024
commit 60fb645815c9b09f526af4d870a27529bf386cbc
3 changes: 3 additions & 0 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@ - (void)_keyboardWillChangeFrame:(NSNotification *)notification
[(UIView *)currentFirstResponder isDescendantOfView:inputAccessoryView]) {
// Text input view is within the inputAccessoryView.
contentDiff = keyboardEndFrame.origin.y - keyboardBeginFrame.origin.y;
} else {
// Text input view is outside of the scroll view.
zhongwuzw marked this conversation as resolved.
Show resolved Hide resolved
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want an early return here? Or should we have a general check for contentDiff == 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to maintain the same logic as the old architecture, which does not perform early return checks or check for contentDiff == 0.

} else {
CGRect viewIntersection = CGRectIntersection(self.firstResponderFocus, keyboardEndFrame);
Expand Down
Loading