Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: debugger blocks other commands when is opened #46624

Closed
wants to merge 1 commit into from

Conversation

coado
Copy link
Contributor

@coado coado commented Sep 24, 2024

Summary:

There is an issue, when the debugger is opened it blocks executing other commands. When the j is clicked it awaits on fetch here, so the _isHandlingKeyPress is not set back to false here, which blocks other commands. I wonder if we just could make the onPress function synchronous, which would solve the problem?

Changelog:

[GENERAL] [FIXED] - Changed onPress to be synchronous

Test Plan:

Tested manually on the new architecture.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 24, 2024
@huntie
Copy link
Member

huntie commented Sep 24, 2024

Thanks so much @coado! I'm going to close this PR, as it's spiritually included in #46627 (🙏🏻) — came across the same fix, and will have a follow up that indeed simplifies onPress to be synchronous/not try to wait for commands to finish.

We'll pick #46627 into the release branch 👍🏻

@huntie huntie closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants