Fix: debugger blocks other commands when is opened #46624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is an issue, when the debugger is opened it blocks executing other commands. When the
j
is clicked it awaits on fetch here, so the _isHandlingKeyPress is not set back tofalse
here, which blocks other commands. I wonder if we just could make the onPress function synchronous, which would solve the problem?Changelog:
[GENERAL] [FIXED] - Changed onPress to be synchronous
Test Plan:
Tested manually on the new architecture.