-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scripts): Support multiple bundles in react-native-xcode.sh #46339
Conversation
This enables projects to have multiple bundles built during the Xcode bundling phase (e.g. for projects where you might have a PhoneScene and a CarPlayScene each with their own RootView and bundle).
cc @cipolleschi thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fivecar to work on this.
I left a small suggestion to improve the code readability and maintainability.
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
Thanks, @cipolleschi! I was the FB LON site lead for its first few years; it's gratifying to have this approved by you. 😄 It looks from the PR that the rest of the workflow needs to be done by maintainers. Please LMK if there's anything else I should be doing on this. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in f8287e2. |
This pull request was successfully merged by @fivecar in f8287e2 When will my fix make it into a release? | How to file a pick request? |
Summary:
This enables projects to have multiple bundles built during the Xcode bundling phase (e.g. for projects where you might have a PhoneScene and a CarPlayScene each with their own RootView and bundle, if you're using react-native-carplay).
Changelog:
[IOS] [ADDED] - User-configurable BUNDLE_NAME when building bundles
Test Plan:
Built my project with the following Xcode "Bundle React Native code" build step:
Then launched the app with a modified
AppDelegate.swift
which loaded main.jsbundle into one RootView and carplay.bundle into another RootView.