Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superflous {type:string} from CodegenSchema #46237

Closed
wants to merge 3 commits into from
Closed

Remove superflous {type:string} from CodegenSchema #46237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80f85bb
Array's with unparsable element tyoe's are explicitly Any vs missing
elicwhite Aug 29, 2024
c6fe07f
Fix NativeModuleEnumMembers type
elicwhite Aug 29, 2024
0e27453
Remove superflous {type:string} from CodegenSchema (#46237)
elicwhite Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove superflous {type:string} from CodegenSchema (#46237) 
Summary:
Pull Request resolved: #46237

I can't find any uses of this, it's not referenced in any fixtures, and flow and typescript both pass without it.

Changelog: [Internal]

Reviewed By: makovkastar

Differential Revision: D61892355
  • Loading branch information
@elicwhite @facebook-github-bot
elicwhite authored and facebook-github-bot committed Aug 29, 2024
commit 0e27453d324b4c8d3cdf7f58fdf86c1ba6792b28
2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/CodegenSchema.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export type NativeModuleEventEmitterTypeAnnotation =
| NativeModuleEventEmitterBaseTypeAnnotation
| {
readonly type: 'ArrayTypeAnnotation';
readonly elementType: NativeModuleEventEmitterBaseTypeAnnotation | { type: string };
readonly elementType: NativeModuleEventEmitterBaseTypeAnnotation;
};

export type NativeModuleBaseTypeAnnotation =
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/CodegenSchema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ export type NativeModuleEventEmitterTypeAnnotation =
| NativeModuleEventEmitterBaseTypeAnnotation
| {
type: 'ArrayTypeAnnotation',
elementType: NativeModuleEventEmitterBaseTypeAnnotation | {type: string},
elementType: NativeModuleEventEmitterBaseTypeAnnotation,
};

export type NativeModuleBaseTypeAnnotation =
Expand Down
Loading