Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Clean up RCTParagraphComponentView & RCTParagraphTextView #46125

Closed
wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Clean up some dead code after some refactoring of RCTParagraphComponentView. cc @cipolleschi

Changelog:

[IOS] [FIXED] - Clean up RCTParagraphComponentView & RCTParagraphTextView

Test Plan:

CI green.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 21, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup. I have been a bit sloppy here. :(

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 9239ad1.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 21, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 9239ad1

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants